With legacy_upload=False, insights-client always returns code 0 for --status. rhc relies/used to rely on legacy behavior, in which the client would return 1 if the host was not registered to Insights. Since insights-client plans to switch to non-legacy for all streams, this will make rhc report incorrect data.
Done criteria:
- rhc properly detects insights-client status, no matter the legacy settings.
Additional information:
- The work has been done upstream, we need to backport this into RHEL 9 and 8.10.z.