What were you trying to do that didn't work?

Failed to hotplug file type serial device

What is the impact of this issue to you?

Please provide the package NVR for which the bug is seen:

libvirt-10.9.0-1.el10.aarch64

qemu-kvm-9.1.0-3.el10.1.aarch64

How reproducible is this bug?:

100%

Steps to reproduce

1. Prepare the file type serial device xml: 

cat serial.xml
<serial type="file">
  <source path="/var/lib/libvirt/serial_file_g75F-1.log"/>
  <target type="system-serial" port="2">
    <model name="pl011"/>
  </target>
  <alias name="ua-serial1"/>
</serial>
 

   2.Hotplug the serial device to guest, unclear error reported:

 # virsh attach-device avocado-vt-vm1 serial.xml
error: Failed to attach device from serial.xml
error: internal error: Invalid target model for serial device

   3.Coldplug the serial device to gues:

# virsh attach-device avocado-vt-vm1 serial-5.xml --config
Device attached successfully 

 4.The same issue with pty type serial device:

<serial type="pty">
  <source path="/dev/pts/1"/>
  <target type="system-serial" port="0">
    <model name="pl011"/>
  </target>
  <alias name="serial1"/>
</serial>  

Expected results

Hotplug should be supported for file type serial device.

Clear error info should be reported when hotplugging pty type serial device.

Actual results

Failed to hotplug file type serial device.