Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-65758

fix: Prevent interface definitions overriding 'changed' value when other elements are changed

    • rhel-sst-system-roles
    • 0
    • QE ack, Dev ack
    • False
    • Hide

      None

      Show
      None
    • Yes
    • None
    • Bug Fix
    • Hide
      .The `firewall` RHEL system role reports `changed: True` when there were changes applied

      During playbook processing, the `firewall_lib.py` module from the `firewall` RHEL system role was replacing the `changed` message with `False` when using the `interface` variable in the playbook and a pre-existing networking interface on the managed node. As a consequence, `firewall` reported the `changed: False` message even when there had been changes done, and the contents from the `forward_port` variable were not saved as permanent. With this update, the `firewall` RHEL system role ensures the `changed` value is not reset to `False`. As a result, the role reports `changed: True` when there are changes, and `forward_port` contents are saved as persistent.
      Show
      .The `firewall` RHEL system role reports `changed: True` when there were changes applied During playbook processing, the `firewall_lib.py` module from the `firewall` RHEL system role was replacing the `changed` message with `False` when using the `interface` variable in the playbook and a pre-existing networking interface on the managed node. As a consequence, `firewall` reported the `changed: False` message even when there had been changes done, and the contents from the `forward_port` variable were not saved as permanent. With this update, the `firewall` RHEL system role ensures the `changed` value is not reset to `False`. As a result, the role reports `changed: True` when there are changes, and `forward_port` contents are saved as persistent.
    • Done
    • None

      Cause: The module was replacing the `changed` value with `False` when using `interface` and the interface exists.

      Consequence: The role reported `changed: False` even when there were changes, and `forward_ports` were not being saved as permanent.

      Fix: Ensure the `changed` value is not reset to `False` in this case.

      Result: The role reports `changed: True` when there are changes, and `forward_ports` settings are persistent.

      This fixes #234

              rmeggins@redhat.com Richard Megginson
              rmeggins@redhat.com Richard Megginson
              Richard Megginson Richard Megginson
              David Jez David Jez
              Jaroslav Klech Jaroslav Klech
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Created:
                Updated: