Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-61421

grubby works on newer OPAL firmware by mistake

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Undefined Undefined
    • None
    • rhel-9.5
    • grubby
    • None
    • No
    • Low
    • rhel-sst-desktop-firmware-bootloaders
    • ssg_display
    • 2
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • None
    • None
    • ppc64le
    • None

      The logic in grubby that determines whether to run grub2-mkconfig on ppc/OPAL is only working because the current firmware version is v1.13-p7b8b64c, rather than v1.13, for example. If v1.13 is passed to grubby, grub2-mkconfig does not run and kernel command line arguments do not get updated because Petitboot cannot read BLS snippets.

      Just take out all the logic wrt Petitboot version and always run grub2-mkconfig on OPAL.

       

      update_grubcfg()
      {
          # Older ppc64le OPAL firmware (petitboot version < 1.8.0) don't have BLS support
          # so grub2-mkconfig has to be run to generate a config with menuentry commands.
          if [ "${arch}" = "ppc64le" ] && [ -d /sys/firmware/opal ]; then
              RUN_MKCONFIG="true"
              petitboot_path="/sys/firmware/devicetree/base/ibm,firmware-versions/petitboot"
              if test -e ${petitboot_path}; then
                  read -r -d '' petitboot_version < ${petitboot_path}
                  petitboot_version="$(echo ${petitboot_version//v})"
                  if test -n ${petitboot_version}; then
                      major_version="$(echo ${petitboot_version} | cut -d . -f1)"
                      minor_version="$(echo ${petitboot_version} | cut -d . -f2)"
                      re='^[0-9]+$'
                      if [[ $major_version =~ $re ]] && [[ $minor_version =~ $re ]] &&
                             ([[ ${major_version} -gt 1 ]] ||
                                  [[ ${major_version} -eq 1 &&
                                       ${minor_version} -ge 8  ]]); then
                          RUN_MKCONFIG="false"
                      fi
      ...
      

       

              bootloader-eng-team bootloader -eng-team
              rhn-support-mlewando Marta Lewandowska
              bootloader -eng-team bootloader -eng-team
              Release Test Team Release Test Team
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: