What were you trying to do that didn't work?

Build firefox on CentOS Stream after latest rebase to version 128.2.0 ESR

Please provide the package NVR for which the bug is seen:

firefox >= 128.2.0

How reproducible is this bug?:

Every time

Steps to reproduce

1. Try to build firefox from c8s or c10s branch (c9s is not yet rebased to 128.2.0 ESR)

Expected results

Successful build

Actual results

/usr/bin/sed: couldn't edit /builddir/build/BUILDROOT/firefox-128.2.0-1.el8.x86_64/usr/lib64/firefox/distribution: not a regular file 

Reason and proposal

After rebase the following code was added to cover CentOS branding needs:

# CentOS
%if 0%{?centos}
%{__sed} -ie 's/redhat/centos/g' %{buildroot}%{mozappdir}/distribution
(source  /etc/os-release; %{__sed} -ie 's/Red Hat Enterprise Linux/$NAME/' %{buildroot}%{mozappdir}/distribution)
cat %{buildroot}%{mozappdir}/distribution
%endif 

This code tries to run sed and cut on %{buildroot}%{mozappdir}/distribution which is a directory, not text file.

I propose to replace this code block with another one which also covers Fedora and all RHEL/CS based distributions:

%{__sed} -e "s/__NAME__/%(source /etc/os-release; echo ${NAME})/g" \
         -e "s/__ID__/%(source /etc/os-release; echo ${ID})/g" \
         -e "s/rhel/redhat/g" \
         -e "s/Fedora.*/Fedora/g" \
       %{SOURCE26} > %{buildroot}%{mozappdir}/distribution/distribution.ini

distribution.ini should be renamed to distribution.ini.in and look like this:

[Global]
id=__ID__
version=1.0
about=Mozilla Firefox for __NAME__

[Preferences]
app.distributor=__ID__
app.distributor.channel=__ID__
app.partner.__ID__=__ID__

I comments I'll provide links to pull requests for CS8 and CS10 now and for CS9 after rebase.