What were you trying to do that didn't work?

As result of CCT-463, now the insights-client systemd service is automatically restarted in case of failure (which is good). The cockpit plugin for subscription-manager has a detection for failed uploads, which checks the state of the systemd service as main criteria; this detection is now broken, since the systemd service is never set as failed anymore.

Please provide the package NVR for which bug is seen:

subscription-manager-cockpit-6-1.el9.noarch
insights-client-3.2.8-1.el9.noarch

How reproducible:

Always

Steps to reproduce

1. Register a system also to Insights
2. Open the Subscriptions page in cockpit
3. Wait for a failed upload of insights-client, maybe forcing one somehow (e.g. adding broken hosts in /etc/hosts)
4. Observe the status of Insights in the plugin

Expected results

• the plugin shows a yellow warning icon (similar to ) next to the "Connected to Insights" text
• clicking on the "Connected to Insights" text shows a popup with the status of Insights, showing a text "The last Insights data upload has failed."

Actual results

The plugin does not show anything about the last failed upload.