Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-50672

Harden /bin/kernel-install to avoid failing silently when /etc/machine-id doesn't end with newline

    • Icon: Story Story
    • Resolution: Done-Errata
    • Icon: Normal Normal
    • rhel-9.5
    • rhel-9.4
    • systemd
    • None
    • systemd-252-41.el9
    • Medium
    • rhel-sst-cs-plumbers
    • ssg_core_services
    • 24
    • 26
    • 1
    • False
    • Hide

      None

      Show
      None
    • None
    • Red Hat Enterprise Linux
    • None
    • None

      Goal

      • When /etc/machine-id doesn't end with a newline character, /bin/kernel-install fails silently in error, which prevents creating the BLS entry for the newly created kernel
        • As an administrator, I would like to be aware that my /etc/machine-id was not correctly created

      Acceptance Criteria

      • Output on stderr an error message stating that /etc/machine-id has not proper format

      Reproducer

      1. Remove trailing newline from /etc/machine-id
        # echo -n $(cat /etc/machine-id) > /etc/machine-id
      2. Install or reinstall a kernel
        # yum reinstall kernel*-5.14.0-427.13.1.el9_4.x86_64

      Result

      [...]
      error: %preun(kernel-core-5.14.0-427.13.1.el9_4.x86_64) scriptlet failed, exit status 1
      
      Error in PREUN scriptlet in rpm package kernel-core
        Running scriptlet: kernel-modules-core-5.14.0-427.13.1.el9_4.x86_64                                                     8/8 
      error: kernel-core-5.14.0-427.13.1.el9_4.x86_64: erase failed
      
        Running scriptlet: kernel-core-5.14.0-427.13.1.el9_4.x86_64                                                             8/8 
      warning: %posttrans(kernel-core-5.14.0-427.13.1.el9_4.x86_64) scriptlet failed, exit status 1
      
      Error in POSTTRANS scriptlet in rpm package kernel-core
      [...]
      Error: Transaction failed
      

              dtardon@redhat.com David Tardon
              rhn-support-rmetrich Renaud Métrich
              David Tardon David Tardon
              Frantisek Sumsal Frantisek Sumsal
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Created:
                Updated:
                Resolved: