-
Bug
-
Resolution: Unresolved
-
Major
-
rhel-7.9.z
-
leapp-repository-0.20.0-12.el7_9
-
Yes
-
Important
-
Regression
-
1
-
rhel-sst-upgrades
-
12
-
4
-
False
-
-
None
-
Red Hat Enterprise Linux
-
Leapp: 9.6 & 10.0
-
Requested
-
None
-
-
All
-
None
What were you trying to do that didn't work?
After the reboot, the upgrade fails while trying to update the cmdline parameters.
Grubby then shows multiple entries are created for the same kernel path when `/etc/sysconfig/kernel` contains
MAKEDEBUG=yes
Please provide the package NVR for which bug is seen:
leapp-upgrade-el7toel8-0.20.0-9.el7_9
How reproducible:
Always
Steps to reproduce
- echo MAKEDEBUG=yes >> /etc/sysconfig/kernel
- leapp upgrade
- reboot
Actual results
Jul 10 10:01:34 localhost upgrade[24251]: 2024-07-10 06:01:34.899 INFO PID: 3 leapp.workflow.Finalization: Executing actor kernelcmdlineconfig Jul 10 10:01:35 localhost upgrade[26325]: 2024-07-10 06:01:35.39 DEBUG PID: 2076 leapp.workflow.Finalization.kernelcmdlineconfig: External command has started: ['grubby', '--update-kernel=/boot/vmlinuz-4.18.0-553.8.1.el8_10.x86_64', '--args', 'net.ifnames=0', '--remove-args', 'debug enforcing=0'] Jul 10 10:01:35 localhost upgrade[26325]: 2024-07-10 06:01:35.321 DEBUG PID: 2076 leapp.workflow.Finalization.kernelcmdlineconfig: External command has finished: ['grubby', '--update-kernel=/boot/vmlinuz-4.18.0-553.8.1.el8_10.x86_64', '--args', 'net.ifnames=0', '--remove-args', 'debug enforcing=0'] Jul 10 10:01:35 localhost upgrade[26325]: 2024-07-10 06:01:35.328 DEBUG PID: 2076 leapp.workflow.Finalization.kernelcmdlineconfig: External command has started: ['grubby', '--info', '/boot/vmlinuz-4.18.0-553.8.1.el8_10.x86_64'] Jul 10 10:01:35 localhost upgrade[26325]: index=0 Jul 10 10:01:35 localhost upgrade[26325]: kernel="/boot/vmlinuz-4.18.0-553.8.1.el8_10.x86_64" Jul 10 10:01:35 localhost upgrade[26325]: args="ro crashkernel=auto spectre_v2=retpoline rd.lvm.lv=rhel/root rd.lvm.lv=rhel/swap rhgb quiet $tuned_params net.ifnames=0" Jul 10 10:01:35 localhost upgrade[26325]: root="/dev/mapper/rhel-root" Jul 10 10:01:35 localhost upgrade[26325]: initrd="/boot/initramfs-4.18.0-553.8.1.el8_10.x86_64.img $tuned_initrd" Jul 10 10:01:35 localhost upgrade[26325]: title="Red Hat Enterprise Linux (4.18.0-553.8.1.el8_10.x86_64) 8.10 (Ootpa)" Jul 10 10:01:35 localhost upgrade[26325]: id="a23d22d7d108455ba60264b08a87d146-4.18.0-553.8.1.el8_10.x86_64" Jul 10 10:01:35 localhost upgrade[26325]: index=1 Jul 10 10:01:35 localhost upgrade[26325]: kernel="/boot/vmlinuz-4.18.0-553.8.1.el8_10.x86_64" Jul 10 10:01:35 localhost upgrade[26325]: args="ro crashkernel=auto spectre_v2=retpoline rd.lvm.lv=rhel/root rd.lvm.lv=rhel/swap rhgb quiet systemd.log_level=debug systemd.log_target=kmsg $tuned_params net.ifnames=0" Jul 10 10:01:35 localhost upgrade[26325]: root="/dev/mapper/rhel-root" Jul 10 10:01:35 localhost upgrade[26325]: initrd="/boot/initramfs-4.18.0-553.8.1.el8_10.x86_64.img $tuned_initrd" Jul 10 10:01:35 localhost upgrade[26325]: title="Red Hat Enterprise Linux (4.18.0-553.8.1.el8_10.x86_64) 8.10 (Ootpa) with debugging" Jul 10 10:01:35 localhost upgrade[26325]: id="a23d22d7d108455ba60264b08a87d146-4.18.0-553.8.1.el8_10.x86_64~debug" Jul 10 10:01:35 localhost upgrade[26325]: 2024-07-10 06:01:35.659 DEBUG PID: 2076 leapp.workflow.Finalization.kernelcmdlineconfig: External command has finished: ['grubby', '--info', '/boot/vmlinuz-4.18.0-553.8.1.el8_10.x86_64'] Jul 10 10:01:35 localhost upgrade[26325]: 2024-07-10 06:01:35.667 WARNING PID: 2076 leapp.workflow.Finalization.kernelcmdlineconfig: Grubby output is malformed: `root=` is listed more than once. Jul 10 10:01:35 localhost upgrade[26325]: 2024-07-10 06:01:35.675 WARNING PID: 2076 leapp.workflow.Finalization.kernelcmdlineconfig: Grubby output is malformed: `args=` is listed more than once. Jul 10 10:01:35 localhost upgrade[26325]: 2024-07-10 06:01:35.682 ERROR PID: 2076 leapp.workflow.Finalization.kernelcmdlineconfig: Grubby listed `args=` multiple times with different values. Jul 10 10:01:35 localhost upgrade[26325]: Process Process-297: Jul 10 10:01:35 localhost upgrade[26325]: Traceback (most recent call last): Jul 10 10:01:35 localhost upgrade[26325]: File "/etc/leapp/repos.d/system_upgrade/common/actors/kernelcmdlineconfig/libraries/kernelcmdlineconfig.py", line 173, in entrypoint Jul 10 10:01:35 localhost upgrade[26325]: modify_kernel_args_in_boot_cfg(configs) Jul 10 10:01:35 localhost upgrade[26325]: File "/etc/leapp/repos.d/system_upgrade/common/actors/kernelcmdlineconfig/libraries/kernelcmdlineconfig.py", line 166, in modify_kernel_args_in_boot_cfg Jul 10 10:01:35 localhost upgrade[26325]: kernel_root, kernel_args = retrieve_args_for_default_kernel(kernel_info) Jul 10 10:01:35 localhost upgrade[26325]: File "/etc/leapp/repos.d/system_upgrade/common/actors/kernelcmdlineconfig/libraries/kernelcmdlineconfig.py", line 128, in retrieve_args_for_default_kernel Jul 10 10:01:35 localhost upgrade[26325]: raise ReadOfKernelArgsError('Grubby listed `args=` multiple' Jul 10 10:01:35 localhost upgrade[26325]: leapp.libraries.actor.kernelcmdlineconfig.ReadOfKernelArgsError: Grubby listed `args=` multiple times with different values. Jul 10 10:01:35 localhost upgrade[26325]: During handling of the above exception, another exception occurred: Jul 10 10:01:35 localhost upgrade[26325]: Traceback (most recent call last): Jul 10 10:01:35 localhost upgrade[26325]: File "/usr/lib64/python3.6/multiprocessing/process.py", line 258, in _bootstrap Jul 10 10:01:35 localhost upgrade[26325]: self.run() Jul 10 10:01:35 localhost upgrade[26325]: File "/usr/lib64/python3.6/multiprocessing/process.py", line 93, in run Jul 10 10:01:35 localhost upgrade[26325]: self._target(*self._args, **self._kwargs) Jul 10 10:01:35 localhost upgrade[26325]: File "/root/tmp_leapp_py3/leapp/repository/actor_definition.py", line 74, in _do_run Jul 10 10:01:35 localhost upgrade[26325]: actor_instance.run(*args, **kwargs) Jul 10 10:01:35 localhost upgrade[26325]: File "/root/tmp_leapp_py3/leapp/actors/__init__.py", line 289, in run Jul 10 10:01:35 localhost upgrade[26325]: self.process(*args) Jul 10 10:01:35 localhost upgrade[26325]: File "/etc/leapp/repos.d/system_upgrade/common/actors/kernelcmdlineconfig/actor.py", line 33, in process Jul 10 10:01:35 localhost upgrade[26325]: kernelcmdlineconfig.entrypoint(configs) Jul 10 10:01:35 localhost upgrade[26325]: File "/etc/leapp/repos.d/system_upgrade/common/actors/kernelcmdlineconfig/libraries/kernelcmdlineconfig.py", line 185, in entrypoint Jul 10 10:01:35 localhost upgrade[26325]: report_hint = reporting.Hints( Jul 10 10:01:35 localhost upgrade[26325]: AttributeError: module 'leapp.reporting' has no attribute 'Hints' Jul 10 10:01:35 localhost upgrade[24251]: 2024-07-10 06:01:35.715 ERROR PID: 3 leapp.workflow.Finalization: Actor kernelcmdlineconfig has crashed: Traceback (most recent call last): Jul 10 10:01:35 localhost upgrade[24251]: File "/etc/leapp/repos.d/system_upgrade/common/actors/kernelcmdlineconfig/libraries/kernelcmdlineconfig.py", line 173, in entrypoint Jul 10 10:01:35 localhost upgrade[24251]: modify_kernel_args_in_boot_cfg(configs) Jul 10 10:01:35 localhost upgrade[24251]: File "/etc/leapp/repos.d/system_upgrade/common/actors/kernelcmdlineconfig/libraries/kernelcmdlineconfig.py", line 166, in modify_kernel_args_in_boot_cfg Jul 10 10:01:35 localhost upgrade[24251]: kernel_root, kernel_args = retrieve_args_for_default_kernel(kernel_info) Jul 10 10:01:35 localhost upgrade[24251]: File "/etc/leapp/repos.d/system_upgrade/common/actors/kernelcmdlineconfig/libraries/kernelcmdlineconfig.py", line 128, in retrieve_args_for_default_kernel Jul 10 10:01:35 localhost upgrade[24251]: raise ReadOfKernelArgsError('Grubby listed `args=` multiple' Jul 10 10:01:35 localhost upgrade[24251]: leapp.libraries.actor.kernelcmdlineconfig.ReadOfKernelArgsError: Grubby listed `args=` multiple times with different values. Jul 10 10:01:35 localhost upgrade[24251]: During handling of the above exception, another exception occurred: Jul 10 10:01:35 localhost upgrade[24251]: Traceback (most recent call last): Jul 10 10:01:35 localhost upgrade[24251]: File "/root/tmp_leapp_py3/leapp/repository/actor_definition.py", line 74, in _do_run Jul 10 10:01:35 localhost upgrade[24251]: actor_instance.run(*args, **kwargs) Jul 10 10:01:35 localhost upgrade[24251]: File "/root/tmp_leapp_py3/leapp/actors/__init__.py", line 289, in run Jul 10 10:01:35 localhost upgrade[24251]: self.process(*args) Jul 10 10:01:35 localhost upgrade[24251]: File "/etc/leapp/repos.d/system_upgrade/common/actors/kernelcmdlineconfig/actor.py", line 33, in process Jul 10 10:01:35 localhost upgrade[24251]: kernelcmdlineconfig.entrypoint(configs) Jul 10 10:01:35 localhost upgrade[24251]: File "/etc/leapp/repos.d/system_upgrade/common/actors/kernelcmdlineconfig/libraries/kernelcmdlineconfig.py", line 185, in entrypoint Jul 10 10:01:35 localhost upgrade[24251]: report_hint = reporting.Hints( Jul 10 10:01:35 localhost upgrade[24251]: AttributeError: module 'leapp.reporting' has no attribute 'Hints' Jul 10 10:01:35 localhost upgrade[24251]: ==================================================================================================== Jul 10 10:01:35 localhost upgrade[24251]: Actor kernelcmdlineconfig unexpectedly terminated with exit code: 1 - Please check the above details Jul 10 10:01:35 localhost upgrade[24251]: ====================================================================================================
WORKAROUND
Simply set MAKEDEBUG=no in /etc/sysconfig/kernel.
NOTES
- I didn't check for 8>9 but I guess the issue is the same. If this case does not match the criteria to be fixed on RHEL 7, please keep the case for 8>9.
- I confirm the regression as the issue does not occur after downgrading leapp*. It could have been introduced by https://github.com/oamg/leapp-repository/commit/2b27cfbbed1059d8af1add3a209d919901897e47
- It seems there is an error while handling the error (2nd traceback)
- The system is fully upgraded afterwards, if the issue already occurred, appending net.ifnames=0 (if applicable) and removing enforcing=0 from the cmdline should be enough (+ touch /.autorelabel and reboot).
- links to
-
RHBA-2024:140181
leapp-repository bug fix and enhancement update
