Description of Problem:

misleading message when setting an invalid display name on RHEL-9.5.0-20240519.9_ppc64le

Please provide the package NVR for which bug is seen:

insights-client-3.2.2-3.el9.noarch

How reproducible

Always

Is this a regression issue:

( Yes/No) 

Steps to Reproduce

• [Step 1] Register RHEL-9.5.0-20240519.9_ppc64le against Satellite

• [Step 2] Register RHEL-9.5.0-20240519.9_ppc64le to insights

• [Step 3] Set an invalid display name:

[root@ibm-p9z-23-lp3 integration-tests]# insights-client --display-name='LIdojGOTMwFadibSHZqJgaoHHQownISlWnrRBxAGMONYawigCbRmaYOIiBFWnhNkOGJehNywdlPPdxAwrqwSkIVAidmkRqFzxlOQwDLKiPWUMEcsaDLNeoMxUDHNjOSrImUFSvEBxacEmmcKxyjaElTvbLLbefvwOBRUmKHTxEKWgjzTRvHlDXihifkvOYsljuQnQSmBR'

System display name changed from hohoho to LIdojGOTMwFadibSHZqJgaoHHQownISlWnrRBxAGMONYawigCbRmaYOIiBFWnhNkOGJehNywdlPPdxAwrqwSkIVAidmkRqFzxlOQwDLKiPWUMEcsaDLNeoMxUDHNjOSrImUFSvEBxacEmmcKxyjaElTvbLLbefvwOBRUmKHTxEKWgjzTRvHlDXihifkvOYsljuQnQSmBR

[root@ibm-p9z-23-lp3 integration-tests]# insights-client --check-results

[root@ibm-p9z-23-lp3 integration-tests]# cat /var/lib/insights/host-details.json | grep display_name

{"total":1,"count":1,"page":1,"per_page":50,"results":[{"insights_id":"572618f1-987b-4f1c-aea2-94887fcab6a0","subscription_manager_id":"572618f1-987b-4f1c-aea2-94887fcab6a0","satellite_id":"572618f1-987b-4f1c-aea2-94887fcab6a0","bios_uuid":null,"ip_addresses":["10.0.2.205"],"fqdn":"ibm-p9z-23-lp3.virt.pnr.lab.eng.rdu2.redhat.com","mac_addresses":["ca:54:8c:44:f6:03","00:00:00:00:00:00"],"provider_id":null,"provider_type":null,"id":"7900eb10-1896-4120-8043-c7486a516f2f","account":"6089719","org_id":"11789772","display_name":"hohoho","ansible_host":null,"facts":[],"reporter":"puptoo","per_reporter_staleness":{"puptoo":{"check_in_succeeded":true,"stale_timestamp":"2024-06-14T12:37:51.746651+00:00","last_check_in":"2024-06-13T07:37:51.746651+00:00","stale_warning_timestamp":"2024-06-20T07:37:51.746651+00:00","culled_timestamp":"2024-06-27T07:37:51.746651+00:00"}},"stale_timestamp":"2024-06-14T12:47:06.213640+00:00","stale_warning_timestamp":"2024-06-20T07:47:06.213640+00:00","culled_timestamp":"2024-06-27T07:47:06.213640+00:00","created":"2024-06-13T07:37:51.781741+00:00","updated":"2024-06-13T07:47:06.213640+00:00","groups":[]}]}

Actual Behavior

As step 3, the invalid display name is not set successfully, but the output message with setting command says:"System display name changed from hohoho to LIdojGOTMwFadibSHZqJgaoHHQownISlWnrRBxAGMONYawigCbRmaYOIiBFWnhNkOGJehNywdlPPdxAwrqwSkIVAidmkRqFzxlOQwDLKiPWUMEcsaDLNeoMxUDHNjOSrImUFSvEBxacEmmcKxyjaElTvbLLbefvwOBRUmKHTxEKWgjzTRvHlDXihifkvOYsljuQnQSmBR"

Expected Behavior

the output message should be like "Could not update display name"

Additional info