Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-39737

Error message is not detailed as before when start vm with negative passt setting

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Minor Minor
    • None
    • rhel-9.5
    • passt
    • None
    • None
    • None
    • rhel-sst-virtualization-networking
    • ssg_virtualization
    • None
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • None

      Description of problem:
      Error message is not detailed as before when start vm with negative passt setting

      Version-Release number of selected component (if applicable):
      passt-0^20240510.g7288448-1.el9.x86_64
      libvirt-10.3.0-2.el9.x86_64

      How reproducible:
      100%

      Steps to Reproduce:
      1. Try to start vm with passt interface, with some negative settings:

      # ip l show eno4
      4: eno4: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc mq state DOWN mode DEFAULT group default qlen 1000
          link/ether e4:43:4b:55:03:d9 brd ff:ff:ff:ff:ff:ff
          altname enp1s0f1
      # virsh dumpxml vm2 --xpath //interface
      <interface type="user">
        <mac address="52:54:00:b8:a6:9a"/>
        <source dev="eno4"/>
        <model type="virtio"/>
        <backend type="passt" logFile="/run/user/107/passt.log"/>
        <address type="pci" domain="0x0000" bus="0x01" slot="0x00" function="0x0"/>
      </interface>
      
      # virsh start vm2
      error: Failed to start domain 'vm2'
      error: internal error: Child process (passt --one-off --socket /run/libvirt/qemu/passt/2-vm2-net0.socket --pid /run/libvirt/qemu/passt/2-vm2-net0-passt.pid --interface eno4 --log-file /run/user/107/passt.log) unexpected exit status 1
      # cat /run/user/107/passt.log
      passt 0^20240510.g7288448-1.el9.x86_64: /usr/bin/passt.avx2 (1793906)
      0.8828: ERROR:   External interface not usable
      

      Actual results:
      The error message is not concrete enough, it says "unexpected exit status 1"

      Expected results:
      The error message can be improved to be more detailed

      Additional info:
      1) with passt-0^20231204.gb86afe3-1.el9.x86_64, the error message is expected

      # virsh start rhel
      error: Failed to start domain 'rhel'
      error: internal error: Child process (passt --one-off --socket /run/libvirt/qemu/passt/1-rhel-net0.socket --pid /run/libvirt/qemu/passt/1-rhel-net0-passt.pid --interface eno4 --log-file /run/user/107/passt.log) unexpected exit status 1: External interface not usable
      

      2) When the xml set without log file, the error message makes sense:

      # # virsh dumpxml vm2 --xpath //interface
      <interface type="user">
        <mac address="52:54:00:b8:a6:9a"/>
        <source dev="eno4"/>
        <model type="virtio"/>
        <backend type="passt"/>
        <address type="pci" domain="0x0000" bus="0x01" slot="0x00" function="0x0"/>
      </interface>
      # virsh start vm2
      error: Failed to start domain 'vm2'
      error: internal error: Child process (passt --one-off --socket /run/libvirt/qemu/passt/1-vm2-net0.socket --pid /run/libvirt/qemu/passt/1-vm2-net0-passt.pid --interface eno4) unexpected exit status 1: External interface not usable
      

      And the same issue will occur when other negative settings like bind to non-exists ip address.

              sbrivio@redhat.com Stefano Brivio
              yalzhang@redhat.com Yalan Zhang
              Stefano Brivio Stefano Brivio
              Lei Yang Lei Yang
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Created:
                Updated:
                Resolved: