Loading...

XML

Word

Printable

Type: Bug
Resolution: Done-Errata
Priority: Undefined
Fix Version/s: rhel-9.5
Affects Version/s: rhel-9.5
Component/s: pcp
Labels:
None

Fixed in Build:
pcp-6.2.2-4.el9
Regression:
None
Severity:
None
sprint_count:
1

Pool Team:

rhel-sst-pt-pcp
Sub-System Group:

ssg_platform_tools

Internal Target Milestone:
22
Story Points:
1
ACKs Check:

QE ack, Dev ack
Blocked:
False
Blocked Reason:

Hide

None

Show
None
Product Documentation Required:
No
Products:

Red Hat Enterprise Linux
Sprint:
PCP Sprint 7

Preliminary Testing:
Pass
Test Link:
https://gitlab.cee.redhat.com/toolchain-qe/tests/pcp/-/tree/master/Sanity/pcp2openmetrics
Errata Link:
https://errata.engineering.redhat.com/advisory/129301
Test Coverage:

Automated

Release Note Type:
Unspecified Release Note Type - Unknown

Experience:
Architecture:

All

SFDC Cases Counter:
SFDC Cases Open:
SFDC Cases Links:

Planning:
None

What were you trying to do that didn't work?

As the Prometheus project is the origin of the OpenMetrics format, I would expect the parser in the Prometheus project will be able to parse the output of pcp2openmetrics tool.

If there is any other way how ensure the syntax of the generated metrics file is correct (except the Prometheus parser I am using) please let me know.

Also feel free to close this issue as Wont-Do if there is no requirement to be compliant with the syntax used by the Prometheus project.

Please provide the package NVR for which bug is seen:

pcp-6.2.2-1.el9

How reproducible:

Always

Steps to reproduce

Generate a file containing some metrics data from the pcp2openmetrics tool

# pcp2openmetrics -a $(ls -1 /var/log/pcp/pmlogger/$(hostname)/*.0 | tail -n 1) -s 1 -F /tmp/x 'kernel.all.load'

Use the data file as an input of the Prometheus parser

# pip3 install --upgrade prometheus_client
# python3 -c 'import sys; from prometheus_client.openmetrics import parser; list(parser.text_string_to_metric_families(sys.stdin.buffer.read().decode("utf-8")))' < /tmp/x

Expected results

The parser is able to parse the file generated by the pcp2openmetrics tool

Actual results

# python3 -c 'import sys; from prometheus_client.openmetrics import parser; list(parser.text_string_to_metric_families(sys.stdin.buffer.read().decode("utf-8")))' < /tmp/x
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/local/lib/python3.9/site-packages/prometheus_client/openmetrics/parser.py", line 18, in text_string_to_metric_families
    yield from text_fd_to_metric_families(StringIO.StringIO(text))
  File "/usr/local/lib/python3.9/site-packages/prometheus_client/openmetrics/parser.py", line 497, in text_fd_to_metric_families
    raise ValueError("Received blank line")
ValueError: Received blank line

Let's remove the first blank line and check it again:

# vim /tmp/x
# python3 -c 'import sys; from prometheus_client.openmetrics import parser; list(parser.text_string_to_metric_families(sys.stdin.buffer.read().decode("utf-8")))' < /tmp/x
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/prometheus_client/openmetrics/parser.py", line 81, in _parse_value
    return int(value)
ValueError: invalid literal for int() with base 10: 'kernel.all.load'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/local/lib/python3.9/site-packages/prometheus_client/openmetrics/parser.py", line 18, in text_string_to_metric_families
    yield from text_fd_to_metric_families(StringIO.StringIO(text))
  File "/usr/local/lib/python3.9/site-packages/prometheus_client/openmetrics/parser.py", line 540, in text_fd_to_metric_families
    sample = _parse_sample(line)
  File "/usr/local/lib/python3.9/site-packages/prometheus_client/openmetrics/parser.py", line 260, in _parse_sample
    value, timestamp, exemplar = _parse_remaining_text(remaining_text)
  File "/usr/local/lib/python3.9/site-packages/prometheus_client/openmetrics/parser.py", line 283, in _parse_remaining_text
    val = _parse_value(split_text[0])
  File "/usr/local/lib/python3.9/site-packages/prometheus_client/openmetrics/parser.py", line 83, in _parse_value
    return float(value)
ValueError: could not convert string to float: 'kernel.all.load'

Let's remove the comment line and check it again:

# vim /tmp/x
# python3 -c 'import sys; from prometheus_client.openmetrics import parser; list(parser.text_string_to_metric_families(sys.stdin.buffer.read().decode("utf-8")))' < /tmp/x
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/prometheus_client/openmetrics/parser.py", line 81, in _parse_value
    return int(value)
ValueError: invalid literal for int() with base 10: 'PCP5'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/local/lib/python3.9/site-packages/prometheus_client/openmetrics/parser.py", line 18, in text_string_to_metric_families
    yield from text_fd_to_metric_families(StringIO.StringIO(text))
  File "/usr/local/lib/python3.9/site-packages/prometheus_client/openmetrics/parser.py", line 540, in text_fd_to_metric_families
    sample = _parse_sample(line)
  File "/usr/local/lib/python3.9/site-packages/prometheus_client/openmetrics/parser.py", line 260, in _parse_sample
    value, timestamp, exemplar = _parse_remaining_text(remaining_text)
  File "/usr/local/lib/python3.9/site-packages/prometheus_client/openmetrics/parser.py", line 283, in _parse_remaining_text
    val = _parse_value(split_text[0])
  File "/usr/local/lib/python3.9/site-packages/prometheus_client/openmetrics/parser.py", line 83, in _parse_value
    return float(value)
ValueError: could not convert string to float: 'PCP5'

Let's remove the ':PCP' line and check it again:

# vim /tmp/x
# python3 -c 'import sys; from prometheus_client.openmetrics import parser; list(parser.text_string_to_metric_families(sys.stdin.buffer.read().decode("utf-8")))' < /tmp/x
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/local/lib/python3.9/site-packages/prometheus_client/openmetrics/parser.py", line 18, in text_string_to_metric_families
    yield from text_fd_to_metric_families(StringIO.StringIO(text))
  File "/usr/local/lib/python3.9/site-packages/prometheus_client/openmetrics/parser.py", line 497, in text_fd_to_metric_families
    raise ValueError("Received blank line")
ValueError: Received blank line

Let's remove the last blank line and check it again:

# vim /tmp/x
# python3 -c 'import sys; from prometheus_client.openmetrics import parser; list(parser.text_string_to_metric_families(sys.stdin.buffer.read().decode("utf-8")))' < /tmp/x
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/local/lib/python3.9/site-packages/prometheus_client/openmetrics/parser.py", line 18, in text_string_to_metric_families
    yield from text_fd_to_metric_families(StringIO.StringIO(text))
  File "/usr/local/lib/python3.9/site-packages/prometheus_client/openmetrics/parser.py", line 614, in text_fd_to_metric_families
    raise ValueError("Missing # EOF at end")
ValueError: Missing # EOF at end

Let's add the missing EOF line and check it again:

# vim /tmp/x
# python3 -c 'import sys; from prometheus_client.openmetrics import parser; list(parser.text_string_to_metric_families(sys.stdin.buffer.read().decode("utf-8")))' < /tmp/x
#

Not the Prometheus parser is able to parse the file. The file, after all the modifications looks like this:

# cat /tmp/x
# HELP kernel_all_load 1, 5 and 15 minute load average
# TYPE kernel_all_load gauge
kernel_all_load{domainname="localdomain",groupid="993",hostname="vm-10-0-186-57.hosted.upshift.rdu2.redhat.com",machineid="03640ff5862a45f5b2944e3ded241caa",userid="993",instname="1 minute",instid="1",agent="linux"} 0.150 1717004975.904928
kernel_all_load{domainname="localdomain",groupid="993",hostname="vm-10-0-186-57.hosted.upshift.rdu2.redhat.com",machineid="03640ff5862a45f5b2944e3ded241caa",userid="993",instname="5 minute",instid="5",agent="linux"} 0.100 1717004975.904928
kernel_all_load{domainname="localdomain",groupid="993",hostname="vm-10-0-186-57.hosted.upshift.rdu2.redhat.com",machineid="03640ff5862a45f5b2944e3ded241caa",userid="993",instname="15 minute",instid="15",agent="linux"} 0.090 1717004975.904928
# EOF

is related to

RHEL-32407 pcp2openmetrics ignores the output file specified via "-F" command line param

Closed

split to

RHEL-46758 [Dev] Output of pcp2openmetrics can not be parsed by Prometheus parser

Closed

links to

RHBA-2024:129301 pcp bug fix and enhancement update

Assignee:: Jan Kurik

Reporter:: Jan Kurik

Developer:: pcp-maint

QA Contact:: Jan Kurik

Doc Contact:: Jacob Valdez (Inactive)

Votes:: 0 Vote for this issue

Watchers:: 8 Start watching this issue

Created:: 2024/05/29 2:26 PM

Updated:: 2024/11/12 8:45 AM

Resolved:: 2024/11/12 8:45 AM

Target end:: 2024/07/29

Release Date:: 2024/11/12

Details

Description

What were you trying to do that didn't work?

Please provide the package NVR for which bug is seen:

How reproducible:

Steps to reproduce

Expected results

Actual results

Attachments

Issue Links

Easy Agile Planning Poker

Activity

People

Dates