• libvirt-10.4.0-1.el9
    • Yes
    • None
    • Regression
    • rhel-sst-virt-tools
    • ssg_virtualization
    • 20
    • 3
    • Dev ack
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • 10.4.0
    • None

      Version-Release number of selected component (if applicable):
      libvirt-10.3.0-1.el9.x86_64

      How reproducible:
      100%

      Steps to Reproduce:

       $ virsh list --help
       error: command 'list' doesn't support option --help
      
      # virt-admin server-list --help
      error: command 'server-list' doesn't support option --help
      

      Expected results:
      '--help' option for virsh/virt-admin can work

            [RHEL-36565] '--help' option for virsh/virt-admin can not work

            Errata Tool added a comment -

            Since the problem described in this issue should be resolved in a recent advisory, it has been closed.

            For information on the advisory (Moderate: libvirt security update), and where to find the updated files, follow the link below.

            If the solution does not work for you, open a new bug report.
            https://access.redhat.com/errata/RHSA-2024:9128

            Errata Tool added a comment - Since the problem described in this issue should be resolved in a recent advisory, it has been closed. For information on the advisory (Moderate: libvirt security update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2024:9128

            The 'blocked by' issue RHEL-29642 is transitioned to Release Pending.

            RHEL Jira bot added a comment - The 'blocked by' issue RHEL-29642 is transitioned to Release Pending.

            Lili Zhu added a comment -

            Verify this bug with:
            libvirt-10.5.0-1.el9.x86_64

            # virt-admin --help
            
            virt-admin [options]... [<command_string>]
            virt-admin [options]... <command> [args...]
            ....
            
            # virsh --help
            
            virsh [options]... [<command_string>]
            virsh [options]... <command> [args...]
            ....
            
            # virsh list --help
              NAME
                list - list domains
            ....
            
            # virt-admin daemon-timeout --help
              NAME
                daemon-timeout - set the auto shutdown timeout of the daemon
            ....
            
            # virt-admin help server-list
              NAME
                server-list - list available servers on a daemon
            
              SYNOPSIS
                server-list
            ....
            
            # virsh help list
              NAME
                list - list domains
            ....
            
            # virt-admin help "Monitoring commands"
             Monitoring commands (help keyword 'monitor'):
                server-list                    list available servers on a daemon
                server-threadpool-info         get server workerpool parameters
                client-list                    list clients connected to <server>
            ....
            
            # virsh help virsh
             Virsh itself (help keyword 'virsh'):
                cd                             change the current directory
                echo                           echo arguments. Used for internal testing.
                exit                           quit this interactive terminal
            ....
            

            As the testing result matches with the expected result, mark the bug as verified.

             

            Lili Zhu added a comment - Verify this bug with: libvirt-10.5.0-1.el9.x86_64 # virt-admin --help virt-admin [options]... [<command_string>] virt-admin [options]... <command> [args...] .... # virsh --help virsh [options]... [<command_string>] virsh [options]... <command> [args...] .... # virsh list --help NAME list - list domains .... # virt-admin daemon-timeout --help NAME daemon-timeout - set the auto shutdown timeout of the daemon .... # virt-admin help server-list NAME server-list - list available servers on a daemon SYNOPSIS server-list .... # virsh help list NAME list - list domains .... # virt-admin help "Monitoring commands" Monitoring commands (help keyword 'monitor'): server-list list available servers on a daemon server-threadpool-info get server workerpool parameters client-list list clients connected to <server> .... # virsh help virsh Virsh itself (help keyword 'virsh'): cd change the current directory echo echo arguments. Used for internal testing. exit quit this interactive terminal .... As the testing result matches with the expected result, mark the bug as verified.  

            Lili Zhu added a comment - - edited

            Tested with:
            libvirt-10.4.0-1.el9.x86_64

            # virsh nodedev-list --help
              NAME
                nodedev-list - enumerate devices on this host
            
              SYNOPSIS
                nodedev-list [--tree] [--cap <string>] [--inactive] [--all] [--persistent] [--transient]
            
              OPTIONS
                --tree           list devices in a tree
                --cap <string>   capability names, separated by comma
                --inactive       list inactive devices
                --all            list inactive & active devices
                --persistent     list persistent devices
                --transient      list transient devices
            
            # virt-admin daemon-log-filters --help
              NAME
                daemon-log-filters - fetch or set the currently defined set of logging filters on daemon
            
              SYNOPSIS
                daemon-log-filters [<filters>]
            
              DESCRIPTION
                Depending on whether run with or without options, the command fetches or redefines the existing active set of filters on daemon.
            
              OPTIONS
                [--filters] <string>  redefine the existing set of logging filters
            

            Mark the Preliminary Testing field as Pass

            Lili Zhu added a comment - - edited Tested with: libvirt-10.4.0-1.el9.x86_64 # virsh nodedev-list --help NAME nodedev-list - enumerate devices on this host SYNOPSIS nodedev-list [--tree] [--cap <string>] [--inactive] [--all] [--persistent] [--transient] OPTIONS --tree list devices in a tree --cap <string> capability names, separated by comma --inactive list inactive devices --all list inactive & active devices --persistent list persistent devices --transient list transient devices # virt-admin daemon-log-filters --help NAME daemon-log-filters - fetch or set the currently defined set of logging filters on daemon SYNOPSIS daemon-log-filters [<filters>] DESCRIPTION Depending on whether run with or without options, the command fetches or redefines the existing active set of filters on daemon. OPTIONS [--filters] <string> redefine the existing set of logging filters Mark the Preliminary Testing field as Pass

            Fixed upstream:

            commit 0fea7a103a57d3599e9841924c2678b7a7b0f794
            Author: Peter Krempa <pkrempa@redhat.com>
            Date:   Wed May 15 08:59:18 2024 +0200
            
                NEWS: Mention '--help' bug in virsh and virt-admin
                
                Signed-off-by: Peter Krempa <pkrempa@redhat.com>
                Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
            
            commit 6d098a0cedf34be26fda5cf79105cd4281e100cb
            Author: Peter Krempa <pkrempa@redhat.com>
            Date:   Wed May 15 08:53:08 2024 +0200
            
                virshtest: Add tests for '--help'
                
                Add test cases for help handling.
                
                Signed-off-by: Peter Krempa <pkrempa@redhat.com>
                Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
            
            commit 811ce0e13b6d319df54e86b8c698e45cfbd8b940
            Author: Peter Krempa <pkrempa@redhat.com>
            Date:   Wed May 15 08:42:57 2024 +0200
            
                vsh: Fix '--help' option for virsh/virt-admin
                
                The refactor of the libvirt tools command parser introduced a bug where
                the '--help' option would cause an error:
                
                 $ virsh list --help
                 error: command 'list' doesn't support option --help
                
                rather than printing the help for the command as the help option is
                supposed to be handled separately from the real options.
                
                Re-introduce the separate handling to the new parser code.
                
                Fixes: 5540c3d2415c194b206f8946cf74b13648163332
                Resolves: https://issues.redhat.com/browse/RHEL-36565
                Reported-by: Lili Zhu <lizhu@redhat.com>
                Signed-off-by: Peter Krempa <pkrempa@redhat.com>
                Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
            
            v10.3.0-70-g0fea7a103a
            
            

            Peter Krempa added a comment - Fixed upstream: commit 0fea7a103a57d3599e9841924c2678b7a7b0f794 Author: Peter Krempa <pkrempa@redhat.com> Date: Wed May 15 08:59:18 2024 +0200 NEWS: Mention '--help' bug in virsh and virt-admin Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Martin Kletzander <mkletzan@redhat.com> commit 6d098a0cedf34be26fda5cf79105cd4281e100cb Author: Peter Krempa <pkrempa@redhat.com> Date: Wed May 15 08:53:08 2024 +0200 virshtest: Add tests for '--help' Add test cases for help handling. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Martin Kletzander <mkletzan@redhat.com> commit 811ce0e13b6d319df54e86b8c698e45cfbd8b940 Author: Peter Krempa <pkrempa@redhat.com> Date: Wed May 15 08:42:57 2024 +0200 vsh: Fix '--help' option for virsh/virt-admin The refactor of the libvirt tools command parser introduced a bug where the '--help' option would cause an error: $ virsh list --help error: command 'list' doesn't support option --help rather than printing the help for the command as the help option is supposed to be handled separately from the real options. Re-introduce the separate handling to the new parser code. Fixes: 5540c3d2415c194b206f8946cf74b13648163332 Resolves: https://issues.redhat.com/browse/RHEL-36565 Reported-by: Lili Zhu <lizhu@redhat.com> Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Martin Kletzander <mkletzan@redhat.com> v10.3.0-70-g0fea7a103a

            Lili Zhu added a comment -

            Lili Zhu added a comment - Fix is on the list: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/XDM6RX3X5VC5C5A6J4JT6PPVG7FZKW6G/

              pkrempa@redhat.com Peter Krempa
              rhn-support-lizhu Lili Zhu
              Peter Krempa Peter Krempa
              Lili Zhu Lili Zhu
              Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

                Created:
                Updated:
                Resolved: