Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-36347

[RHEL10] accel-config: Don't list attributes not present

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Undefined Undefined
    • None
    • rhel-10.0.beta
    • accel-config
    • None
    • None
    • None
    • rhel-sst-kernel-ft
    • ssg_core_kernel
    • 15
    • 17
    • 1
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • None
    • None
    • x86_64
    • None

      What were you trying to do that didn't work?

      If you save a config on a system where some attributes aren't present, and then attempt to load the saved config again it will fail to load the config. The json code doesn't check to see if it got an error when trying to read in a non-present attribute from the system, and puts the errno into the json code for the attributes value.

      Upstream fix is:

      ea015cc437e6 ("accel-config: Don't list attributes not present")

      Please provide the package NVR for which bug is seen:

      accel-config-4.1.6-2.el9 and earlier. I'll come up with the nvr for when it started looking for the potentially non-present attributes.

      How reproducible:

      100% on system like a birchstream-srf with iax devices enabled.

      Steps to reproduce

      1. Reserve system with like mentioned above with iax devices.
      2. Install accel-config
      3. Install accel-config-test from buildroot
      4. cd /usr/libexec/accel-config/test
      5. disable all wqs and devices currently enabled (look at accel-config list output or run attached script).
      6. accel-config load-config -e -c configs/2g2q_user_2.conf
      7. accel-config save-config -s tmp.conf
      8. disable the wqs and devices again (in this case the attached script won't work, because their test config uses wq 1.1 and 1.4, and the script currently just cleans up the default workqueues that end with .0 that are configured during boot when iaa_crypto is loaded. I'll try to come up with another script that cleans up any that exist)
      9. accel-config load-config -c tmp.conf

      Expected results

      Config successfully loads

      Actual results

      [root@intel-birchstream-srf-sp-03 test]# accel-config load-config -c tmp.conf 
      libaccfg: accfg_wq_set_max_batch_size: wq1.1: max_batch_size attribute write failed: No such file or directory
      wq set max_batch_size value failed
      Parse json and set device fail: -1
      

              rhn-support-jsnitsel Jerry Snitselaar
              rhn-support-jsnitsel Jerry Snitselaar
              Jerry Snitselaar Jerry Snitselaar
              William Gomeringer William Gomeringer
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: