Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-3630

95nvmf: Move /etc/nvme/host{nqn,id} checks

    • Icon: Bug Bug
    • Resolution: Done-Errata
    • Icon: Critical Critical
    • rhel-9.4
    • rhel-9.3.0
    • dracut
    • None
    • dracut-057-53.git20240104.el9
    • None
    • None
    • rhel-sst-cs-plumbers
    • ssg_core_services
    • 26
    • None
    • Dev ack
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • All
    • None

      The NBFT support inclusion back in dracut-057-38.git20230725.el9 brought new requirements in the module-setup.sh check() section - the /etc/nvme/hostnqn and /etc/nvme/hostid files.

      These files contain machine-specific UUID values and are not supposed to be included in an generic installation images. Since we intentionally remove these by lorax during installation ISO creation, the dracut run that creates installation initramfs skips the nvmf module inclusion due to unsatisfied requirements.

      Proposed change:

      diff -up dracut-057/modules.d/95nvmf/module-setup.sh.old dracut-057/modules.d/95nvmf/module-setup.sh
      --- dracut-057/modules.d/95nvmf/module-setup.sh.old    2023-09-12 15:18:36.492824362 +0200
      +++ dracut-057/modules.d/95nvmf/module-setup.sh    2023-09-12 15:19:04.475563194 +0200
      @@ -3,8 +3,6 @@
       # called by dracut
       check() {
           require_binaries nvme jq || return 1
      -    [ -f /etc/nvme/hostnqn ] || return 255
      -    [ -f /etc/nvme/hostid ] || return 255
      
           is_nvmf() {
               local _dev=$1
      @@ -36,6 +34,8 @@ check() {
           }
      
           [[ $hostonly ]] || [[ $mount_needs ]] && {
      +        [ -f /etc/nvme/hostnqn ] || return 255
      +        [ -f /etc/nvme/hostid ] || return 255
               pushd . > /dev/null
               for_each_host_dev_and_slaves is_nvmf
               local _is_nvmf=$?
      

      Need to discuss this further with interested parties and upstream. The whole HostNQN story in RHEL and Fedora is still rather unclear. This however fixes some problems we're seeing in 9.3

              pvalena@redhat.com Pavel Valena
              tbzatek Tomáš Bžatek
              dracut maint mailing list dracut maint mailing list
              Frantisek Sumsal Frantisek Sumsal
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Created:
                Updated:
                Resolved: