Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-35998

Drop dependency from libguestfs -> gdisk

    • Icon: Story Story
    • Resolution: Unresolved
    • Icon: Undefined Undefined
    • rhel-10.0.beta
    • None
    • libguestfs
    • None
    • sst_virtualization
    • ssg_virtualization
    • 5
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • None
    • None
    • None

      libguestfs depends on gdisk to implement some APIs. However plain old fdisk can now implement the same operations, so we no longer need to depend on gdisk.

      This will require some changes to libguestfs internals.

      We actually only use sgdisk, and we use it for the following libguestfs APIs (I've left off the guestfs_ prefix):

      • part_expand_gpt
      • part_set_disk_guid
      • part_get_disk_guid
      • part_set_disk_guid_random
      • part_set_gpt_attributes
      • part_get_gpt_attributes
      • part_set_gpt_guid
      • part_get_gpt_guid
      • part_set_gpt_type
      • part_get_gpt_type

      (See current implementation here:
      https://github.com/libguestfs/libguestfs/blob/e2c7bddf10c99baaf657a382ef0a7cf835c561db/daemon/parted.c )

      These APIs are used by virt-inspector and virt-resize, which are both fairly crucial. Actually, part_expand_gpt which is the hard one is not used at all by our tools.

      sfdisk is now able to implement all except part_expand_gpt:

      • part_(set,get)_disk_guid: sfdisk --disk-id
      • part_set_disk_guid_random: sfdisk --disk-id with a self-generated random number
      • part_(set,get)_gpt_attributes: sfdisk --part-attrs
      • part_(set,get)_gpt_guid: sfdisk --part-uuid
      • part_(set,get)_gpt_type: sfdisk --part-type

            rhn-eng-rjones Richard Jones
            rhn-eng-rjones Richard Jones
            Yongkui Guo Yongkui Guo
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated: