Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-35988

boom does not enable Red Hat optional keys by default on RHEL8

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Do
    • Icon: Major Major
    • None
    • rhel-8.8.0, rhel-8.9.0, rhel-8.10
    • boom-boot
    • None
    • Yes
    • Moderate
    • Patch, Regression
    • e58bc7b29ac58629b0a93b1e38a4fa2efd0017b6
    • rhel-sst-logical-storage
    • ssg_filesystems_storage_and_HA
    • 1
    • False
    • Hide

      None

      Show
      None
    • None
    • Red Hat Enterprise Linux
    • None
    • None
    • None
    • All
    • None

      What were you trying to do that didn't work?

      Create a boom OsProfile using --from-host from the upgrade/rollback process documented here:

      https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/managing_storage_devices/managing-system-upgrades-with-snapshots_managing-storage-devices

      The optional keys value is set incorrectly for the RHEL8 profile. This prevents the boom-managed entries from appearing in the grub2 menu on ppc64le.

      Please provide the package NVR for which bug is seen:

      boom-boot-1.3-2.el8.noarch

      How reproducible:

      100%

      Steps to reproduce

      1. grub integration warning from boom create:

      [root@localhost ~]# boom profile create --from-host

      Expected results

      [root@localhost ~]# boom profile create --from-host
Created profile with os_id 43747d3:
  OS ID: "43747d3888b663d2bc88efd35d0813159a84d291",
  Name: "Red Hat Enterprise Linux", Short name: "rhel",
  Version: "8.9 (Ootpa)", Version ID: "8.9",
  Kernel pattern: "/vmlinuz-%{version}", Initramfs pattern: "/initramfs-%{version}.img",
  Root options (LVM2): "rd.lvm.lv=%{lvm_root_lv}",
  Root options (BTRFS): "rootflags=%{btrfs_subvolume}",
  Options: "root=%{root_device} ro %{root_opts}",
  Title: "%{os_name} %{os_version_id} (%{version})",
  Optional keys: "grub_users grub_arg grub_class id", UTS release pattern: "el8"

      Actual results

      [root@localhost ~]# boom profile create --from-host
Created profile with os_id 43747d3:
  OS ID: "43747d3888b663d2bc88efd35d0813159a84d291",
  Name: "Red Hat Enterprise Linux", Short name: "rhel",
  Version: "8.9 (Ootpa)", Version ID: "8.9",
  Kernel pattern: "/vmlinuz-%{version}", Initramfs pattern: "/initramfs-%{version}.img",
  Root options (LVM2): "rd.lvm.lv=%{lvm_root_lv}",
  Root options (BTRFS): "rootflags=%{btrfs_subvolume}",
  Options: "root=%{root_device} ro %{root_opts}",
  Title: "%{os_name} %{os_version_id} (%{version})",
  Optional keys: "", UTS release pattern: "el8"

      The optional keys list is empty when it should be "grub_users grub_arg grub_class id"

      This leads to boot entries being created without the optional keys:

      [root@localhost ~]# boom create --backup --title "Root LV snapshot before changes" --rootlv rhel/root_snapshot_before_changes
Created entry with boot_id 9b86cc4:
  title Root LV snapshot before changes
  machine-id d8fec42059664eae9e9ffe57de381c78
  version 4.18.0-513.24.1.el8_9.x86_64
  linux /vmlinuz-4.18.0-513.24.1.el8_9.x86_64.boom0
  initrd /initramfs-4.18.0-513.24.1.el8_9.x86_64.img.boom0
  options root=/dev/rhel/root_snapshot_before_changes ro rd.lvm.lv=rhel/root_snapshot_before_changes

      vs.

      [root@localhost ~]# boom create --backup --title "Root LV snapshot before changes" --rootlv rhel/root_snapshot_before_changes
Created entry with boot_id 5f9e916:
  title Root LV snapshot before changes
  machine-id 6db8de82fe42457a93cb9fab744d2e99
  version 4.18.0-513.24.1.el8_9.x86_64
  linux /vmlinuz-4.18.0-513.24.1.el8_9.x86_64.boom0
  initrd /initramfs-4.18.0-513.24.1.el8_9.x86_64.img.boom0
  options root=/dev/rhel/root_snapshot_before_changes ro rd.lvm.lv=rhel/root_snapshot_before_changes
  grub_users $grub_users
  grub_arg --unrestricted
  grub_class kernel

      Upstream status

      This has been fixed upstream in the following commits:

      commit e58bc7b29ac58629b0a93b1e38a4fa2efd0017b6
Author: Bryn M. Reeves <bmr@redhat.com>
Date:   Tue Jun 14 09:31:33 2022 -0400

    boom.command: add new os-release values to Red Hat optional keys list
    
    Add "Red Hat Enterprise Linux" (NAME for el8 onwards), and "Fedora
    Linux" (NAME for fc35 onwards) to the table of names to automatically
    enable grub optional keys for.
    
    Signed-off-by: Bryn M. Reeves <bmr@redhat.com>

              lvm-team lvm-team
              rhn-support-bmr Bryn Reeves
              lvm-team lvm-team
              Cluster QE Cluster QE
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: