Loading...

Type: Bug
Resolution: Won't Do
Priority: Major
Fix Version/s: None
Affects Version/s: rhel-8.8.0, rhel-8.9.0, rhel-8.10
Component/s: boom-boot
Labels:
None

Regression:
Yes
Severity:
Moderate
Epic Link:
RHEL-36337
Keywords:

Patch, Regression
Commit Hashes:

Hide
2721baa62e414dcbe1fdd3ab2a7f1cf5f2ac4dc4
b64d59cd1c9b798cfe4f7fd2e8e022dbc75082e3
115259492699a101bc6f9497bb438194cbe4d042

Show
2721baa62e414dcbe1fdd3ab2a7f1cf5f2ac4dc4 b64d59cd1c9b798cfe4f7fd2e8e022dbc75082e3 115259492699a101bc6f9497bb438194cbe4d042

Pool Team:

rhel-sst-logical-storage
Sub-System Group:

ssg_filesystems_storage_and_HA

Story Points:
1
Blocked:
False
Blocked Reason:

Hide

None

Show
None
Product Documentation Required:
None
Products:

Red Hat Enterprise Linux
Sprint:
None

Preliminary Testing:
None
Test Coverage:
None

Experience:
Architecture:

All

SFDC Cases Counter:
SFDC Cases Open:
SFDC Cases Links:

Planning:
None

What were you trying to do that didn't work?

Create a boom boot entry and list boot entries post-upgrade using the upgrade/rollback process documented here:

https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/managing_storage_devices/managing-system-upgrades-with-snapshots_managing-storage-devices

Although these are just spurious warnings the impact the upgrade/rollback user experience for leapp upgrades from RHEL8 to RHEL9.

Please provide the package NVR for which bug is seen:

boom-boot-1.3-2.el8.noarch

How reproducible:

100%

Steps to reproduce

1. grub integration warning from boom create:

[root@localhost ~]# boom create --backup --title "Root LV snapshot before changes" --rootlv rhel/root_snapshot_before_changes

This warning (and the configuration file it references) are obsolete since RHEL8 uses BLS by default. The warning has been removed in later versions of boom.

2. read-only warning when listing boot entries post-upgrade:

[root@localhost ~]# boom list

Expected results

1. boom create

[root@localhost ~]# boom create --backup --title "Root LV snapshot before changes" --rootlv rhel/root_snapshot_before_changes
Created entry with boot_id 9d7df77:
  title Root LV snapshot before changes
  machine-id 6db8de82fe42457a93cb9fab744d2e99
  version 4.18.0-513.24.1.el8_9.x86_64
  linux /vmlinuz-4.18.0-513.24.1.el8_9.x86_64.boom0
  initrd /initramfs-4.18.0-513.24.1.el8_9.x86_64.img.boom0
  options root=/dev/rhel/root_snapshot_before_changes ro rd.lvm.lv=rhel/root_snapshot_before_changes

2. boom list

[root@localhost ~]# boom list
BootID  Version                      Name                     RootDevice                            
1e1a9b4 4.18.0-513.5.1.el8_9.x86_64  Red Hat Enterprise Linux /dev/mapper/rhel-root                 
4ea37b9 4.18.0-513.24.1.el8_9.x86_64 Red Hat Enterprise Linux /dev/mapper/rhel-root                 
e22dd61 5.14.0-362.24.1.el9_3.x86_64 Red Hat Enterprise Linux /dev/mapper/rhel-root                 
6e810cc 4.18.0-513.24.1.el8_9.x86_64 Red Hat Enterprise Linux /dev/rhel/root_snapshot_before_changes

Actual results

1. boom create

[root@localhost ~]# boom create --backup --title "Root LV snapshot before changes" --rootlv rhel/root_snapshot_before_changes
WARNING - Boom grub2 integration is disabled in '/boot/../etc/default/boom'
Created entry with boot_id 9d7df77:
  title Root LV snapshot before changes
  machine-id 6db8de82fe42457a93cb9fab744d2e99
  version 4.18.0-513.24.1.el8_9.x86_64
  linux /vmlinuz-4.18.0-513.24.1.el8_9.x86_64.boom0
  initrd /initramfs-4.18.0-513.24.1.el8_9.x86_64.img.boom0
  options root=/dev/rhel/root_snapshot_before_changes ro rd.lvm.lv=rhel/root_snapshot_before_changes

2. boom list

[root@localhost ~]# boom list
WARNING - Options for BootEntry(boot_id=1e1a9b4) do not match OsProfile: marking read-only
WARNING - Options for BootEntry(boot_id=1a8e444) do not match OsProfile: marking read-only
WARNING - Options for BootEntry(boot_id=4ea37b9) do not match OsProfile: marking read-only
BootID  Version                      Name                     RootDevice                            
1e1a9b4 4.18.0-513.5.1.el8_9.x86_64  Red Hat Enterprise Linux /dev/mapper/rhel-root                 
4ea37b9 4.18.0-513.24.1.el8_9.x86_64 Red Hat Enterprise Linux /dev/mapper/rhel-root                 
e22dd61 5.14.0-362.24.1.el9_3.x86_64 Red Hat Enterprise Linux /dev/mapper/rhel-root                 
6e810cc 4.18.0-513.24.1.el8_9.x86_64 Red Hat Enterprise Linux /dev/rhel/root_snapshot_before_changes

Upstream status

These have been fixed upstream in the following commits:

commit 115259492699a101bc6f9497bb438194cbe4d042
Author: Bryn M. Reeves <bmr@redhat.com>
Date:   Fri Jul 16 18:11:07 2021 +0100

    boom: remove BOOM_ENTRY_OPTIONS hack from BootEntry.__from_data()
    
    Commit 92c2bce3 moved logic for accounting for add/del opts from
    the BootParams.from_entry() method into BootEntry.__from_data().
    Although this is the more correct location to make these changes
    the rewriting of the stored BOOM_ENTRY_OPTIONS value is actually
    redundant: the entire value will be cleared by the pop-if-set
    logic applied to all template-generated keys in the final stage
    of loading a BootEntry from an entry_data array.
    
    Additionally the logic conflicts with the handling of host profile
    options modifications causing entries with an attached HostProfile
    to unexpectedly change boot_id.
    
    Remove the special handling of BOOM_ENTRY_OPTIONS and simplify the
    BootEntry.__from_data() method.
    
    Signed-off-by: Bryn M. Reeves <bmr@redhat.com>

commit b64d59cd1c9b798cfe4f7fd2e8e022dbc75082e3
Author: Bryn M. Reeves <bmr@redhat.com>
Date:   Thu May 19 16:46:19 2022 +0100

    boom: drop Grub2 integration scripts and defaults file
    
    Remove the 42_boom grub2-mkconfig hook script and the boom grub2
    integration configuration in /etc/default/boom and fix the corresponding
    test cases accordingly.
    
    Closes: #2
    
    Signed-off-by: Bryn M. Reeves <bmr@redhat.com>

commit 2721baa62e414dcbe1fdd3ab2a7f1cf5f2ac4dc4
Author: Bryn M. Reeves <bmr@redhat.com>
Date:   Thu May 19 16:25:19 2022 +0100

    boom.bootloader: simplify bootloader integration checks
    
    Since Red Hat distributions (since RHEL8/Fedora 30) now default to using
    BLS for boot loader configuration the boom grub integration scripts
    (that are run during grub2-mkconfig execution), and the elaborate checks for
    various details of the integration are unnecessary and lead to
    misleading output when boom is used on these distributions:
    
      # boom create --title "STRATIS SNAP TEST2" --root-device /dev/stratis/p1/fs1-snap
      WARNING - Boom configuration file missing from '/boot/../etc/default/boom'
      WARNING - Boom configuration not found in grub.cfg
      WARNING - Run 'grub2-mkconfig > /boot/grub2/grub.cfg' to enable
      Created entry with boot_id 0b0a8d0:
        title STRATIS SNAP TEST2
        machine-id 568bd2491ba243d48fcff8f2a2d7f928
        version 5.11.12-300.fc34.x86_64
        linux /vmlinuz-5.11.12-300.fc34.x86_64
        initrd /initramfs-5.11.12-300.fc34.x86_64.img
        options root=/dev/stratis/p1/fs1-snap ro stratis.rootfs.pool_uuid=7e12536d-ddd5-4042-9d84-fff9846f4603
        grub_users $grub_users
        grub_arg --unrestricted
        grub_class kernel
    
    The WARNING messages are not only misleading but potentially harmful
    since running grub2-mkconfig may have additional side-effects depending
    on the system configuration (and may not enable blscfg if for some
    reason it is not present in the configuration files in /boot).
    
    An additional benefit of this simplification is that it now correctly
    reports the BLS status for systems using EFI.

Details

Description

What were you trying to do that didn't work?

Please provide the package NVR for which bug is seen:

How reproducible:

Steps to reproduce

Expected results

Actual results

Upstream status

Attachments

Easy Agile Planning Poker

Activity

People

Dates