Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-31980

Checkpoint rollback does not restore profile back to in-memory state

XMLWordPrintable

    • NetworkManager-1.47.90-1.el9
    • None
    • Important
    • ZStream
    • 1
    • rhel-sst-network-management
    • ssg_networking
    • 14
    • 5
    • False
    • Hide

      None

      Show
      None
    • None
    • NMT - RHEL-9.5 DTM 12
    • Approved Blocker
    • Hide

      Given a system with checkpoint protecting in-memory profile in NetworkManager,
      When user converted these in-memory profiles into persistent and do rollback,
      Then those persistent profiles should be removed and replaced with original in-memory profile.

      Definition of Done:

      • The implementation meets the acceptance criteria
      • Integration tests are written and pass
      • The fix is part of a downstream build attached to an errata
      • The fix is backported into RHEL-9.2 (OCP 4.16 initially will use RHEL 9.2.z)

       

      AC and QE test alignment:

      The snapshot_rollback_in_memory test has been added and is testing that in-memory connection is not persistent after rollback: https://gitlab.freedesktop.org/NetworkManager/NetworkManager-ci/-/merge_requests/1692

      Show
      Given a system with checkpoint protecting in-memory profile in NetworkManager, When user converted these in-memory profiles into persistent and do rollback, Then those persistent profiles should be removed and replaced with original in-memory profile. Definition of Done: The implementation meets the acceptance criteria Integration tests are written and pass The fix is part of a downstream build attached to an errata The fix is backported into RHEL-9.2 (OCP 4.16 initially will use RHEL 9.2.z)   AC and QE test alignment: The snapshot_rollback_in_memory test has been added and is testing that in-memory connection is not persistent after rollback: https://gitlab.freedesktop.org/NetworkManager/NetworkManager-ci/-/merge_requests/1692
    • Pass
    • None
    • None

      What were you trying to do that didn't work?

      Given a system with checkpoint protecting in-memory profile in NetworkManager,
      When user converted these in-memory profiles into persistent and do rollback,
      Then those persistent profiles should be removed and replaced with original in-memory profile

      Please provide the package NVR for which bug is seen:

      NetworkManager-1.47.4-33201.copr.0bb37455c3.el9.x86_64

      How reproducible:

      100%

      Steps to reproduce

      #!/bin/bash -x

echo '---
interfaces:
- name: dummy1
  type: dummy
' | nmstatectl set - --memory-only

echo "Before creating checkpoint"
PAGER="" nmcli -f 'filename,name,uuid' c show

echo '
---
interfaces:
- name: dummy1
  type: dummy
' | nmstatectl set - --no-commit

nmstatectl rollback

echo "After checkpoint rollback"
PAGER="" nmcli -f 'filename,name,uuid' c show

      Expected results

      The `dummy1` profile restored back to in-memory (stored in /run/NetworkManager/system-connections folder)

      Actual results

      The `dummy1` profile is stored as persistent profile in /etc/NetworkManager/ssytem-connections folder

        1. nm.log
          125 kB

              bgalvani@redhat.com Beniamino Galvani
              fge@redhat.com Gris Ge
              Network Management Team Network Management Team
              Filip Pokryvka Filip Pokryvka
              Votes:
              0 Vote for this issue
              Watchers:
              13 Start watching this issue

                Created:
                Updated:
                Resolved: