Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-30357

storage/nvdimm/ndctl-test-suite fails to build on 9.0

    • None
    • None
    • rhel-sst-storage-io
    • ssg_filesystems_storage_and_HA
    • None
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • None
    • None
    • None

      The ndctl kernel test @ https://gitlab.com/redhat/centos-stream/tests/kernel/kernel-tests/-/blob/main/storage/nvdimm/ndctl-test-suite/runtest.sh?ref_type=heads fails to run on RHEL 9.0

      In the test run https://datawarehouse.cki-project.org/kcidb/tests/11786155 we can see

      :: [ 11:46:02 ] :: [ FAIL ] :: Command 'make TESTS=libndctl check' (Expected 0, got 2)
      

      which when we check the task log https://s3.upshift.redhat.com/DH-PROD-CKI/internal-artifacts/1226426444/test_x86_64/6469847020/artifacts/run.done.01/job.01/recipes/15799091/tasks/11/logs/taskout.log comes down to

      ../test/libndctl.c: In function ‘check_btt_size’:
      ../test/libndctl.c:989:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
        989 |         unsigned long long expect_table[][2] = {
            |         ^~~~~~~~
      

      I can see this is fixed by an old patch https://git.centos.org/rpms/ndctl/blob/c9/f/SOURCES/0003-ndctl-test-Fix-btt-expect-table-compile-warning.patch

      I feel like this must have worked at some point, so I'm not sure what's going on? Would we say the 9.0 package needs this patch so it builds tests on 9.0?

              rhn-support-jmoyer Jeff Moyer
              rhn-engineering-iwienand Ian Wienand
              Jeff Moyer Jeff Moyer
              Yi Zhang Yi Zhang
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: