Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-25509

fix: Allow tangd socket override directory to be managed outside of the role

XMLWordPrintable

    • rhel-system-roles-1.23.0-2.17.el8
    • None
    • None
    • rhel-sst-system-roles
    • 25
    • 26
    • 2
    • QE ack, Dev ack
    • False
    • Hide

      None

      Show
      None
    • Yes
    • Red Hat Enterprise Linux
    • None
    • Bug Fix
    • Hide
      .`nbde_server` role now works with socket overrides

      Previously, the `nbde_server` RHEL System Role assumed that the only file in the `tangd` socket override directory was the `override.conf` file for a custom port. Consequently, the role deleted the directory if there was no port customization without checking other files, and the system re-created the directory in subsequent runs.

      With this release, the role has been fixed to prevent changing attributes of the port override file and deleting the directory if there are other files. As a result, the role correctly works if `tangd` socket override files are managed also outside of the role.
      Show
      .`nbde_server` role now works with socket overrides Previously, the `nbde_server` RHEL System Role assumed that the only file in the `tangd` socket override directory was the `override.conf` file for a custom port. Consequently, the role deleted the directory if there was no port customization without checking other files, and the system re-created the directory in subsequent runs. With this release, the role has been fixed to prevent changing attributes of the port override file and deleting the directory if there are other files. As a result, the role correctly works if `tangd` socket override files are managed also outside of the role.
    • Done
    • None

      Cause: The role was assuming that the only file being managed in the tangd
      socket override directory was the override.conf file for the custom port.

      Consequence: The role would delete the directory if there was no custom port
      without checking if there were other files in that directory being used to
      override tangd settings. This would cause the directory to be recreated
      upon subsequent runs, and the role would report a change, and not appear
      to be idempotent.

      Fix: When adding the override directory for the port override file, do not
      change its attributes. Do not delete the directory if there are other files
      in it.

      Result: The role will co-exist with the tangd socket override files being
      managed outside of the role.

      Signed-off-by: Rich Megginson <rmeggins@redhat.com>

      Fixes https://github.com/linux-system-roles/nbde_server/issues/138

              rmeggins@redhat.com Richard Megginson
              rmeggins@redhat.com Richard Megginson
              Richard Megginson Richard Megginson
              David Jez David Jez
              Mirek Jahoda Mirek Jahoda
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Created:
                Updated:
                Resolved: