Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-2501

Accept comma separated list of values for all properties of flag type

XMLWordPrintable

    • rhel-sst-network-management
    • ssg_networking
    • 3
    • False
    • Hide

      None

      Show
      None
    • Yes
    • Red Hat Enterprise Linux
    • None
    • Hide

      Given a system with NetworkManager installed and a system administrator who wants to modify a property of type "flags",

      When the administrator tries to set the value of the property using a comma-separated list of flag names: `nmcli c modify CON-NAME setting.property flag1,flag2`

      Then NetworkManager should interpret the comma-separated list as the OR combination of all the listed flags and the property value should update correctly, reflecting the combined value of `flag1` OR `flag2`.

      Given the same setup,

      When the system administrator tries to introduce the value of the property using a space-separated list of flag names: `nmcli c modify CON-NAME setting.property flag1 flag2`

      Then NetworkManager should interpret the space-separated list in the same way as the comma-separated list and the property value should update accordingly.

      Given the same setup,

      When the system administrator introduces a decimal numeric value for the flag,

      Then NetworkManager should accept and recognize decimal values, not just hexadecimal ones and the property value should update to reflect the introduced decimal value.

      Given the enhanced flag modification capability,

      When the system administrator uses the `+flagname` / `-flagname` syntax to add or remove specific flags,

      Then NetworkManager should correctly add (or remove) the specified flags from the property's existing value and the updated property value should reflect the addition or removal of the mentioned flags.

      Definition of Done:

      • The implementation meets the acceptance criteria
      • Unit test and integration test are written and pass
      • the fix is part of a downstream build attached to an errata
      • The initial text for this enhancement in the feature-reason-result format (More details here)
      Show
      Given a system with NetworkManager installed and a system administrator who wants to modify a property of type "flags", When the administrator tries to set the value of the property using a comma-separated list of flag names: `nmcli c modify CON-NAME setting.property flag1,flag2` Then NetworkManager should interpret the comma-separated list as the OR combination of all the listed flags and the property value should update correctly, reflecting the combined value of `flag1` OR `flag2`. Given the same setup, When the system administrator tries to introduce the value of the property using a space-separated list of flag names: `nmcli c modify CON-NAME setting.property flag1 flag2` Then NetworkManager should interpret the space-separated list in the same way as the comma-separated list and the property value should update accordingly. Given the same setup, When the system administrator introduces a decimal numeric value for the flag, Then NetworkManager should accept and recognize decimal values, not just hexadecimal ones and the property value should update to reflect the introduced decimal value. Given the enhanced flag modification capability, When the system administrator uses the `+flagname` / `-flagname` syntax to add or remove specific flags, Then NetworkManager should correctly add (or remove) the specified flags from the property's existing value and the updated property value should reflect the addition or removal of the mentioned flags. Definition of Done: The implementation meets the acceptance criteria Unit test and integration test are written and pass the fix is part of a downstream build attached to an errata The initial text for this enhancement in the feature-reason-result format (More details here )
    • None
    • None
    • Enhancement
    • All
    • None

      What were you trying to do that didn't work?

      Introduce the value of a property of type "flags" using a comma or space separated list of flag names. Only the hexadecimal numeric value was accepted.

      I don't remember what property it was. In some it works, in others not.

      Note: should we also support adding and removing flags with `+flagname` / `-flagname`? Is it already supported?

      Please provide the package NVR for which bug is seen:

      How reproducible:

      Steps to reproduce

      1. nmcli c modify CON-NAME setting.property flag1,flag2

      Expected results

      The value is accepted as if it was the OR combination of all the listed flags

      Alternatively, a decimal numeric value is accepted, not only an hexadecimal one.

      Also, accept adding / removing flags with `+flagname` / `-flagname`?

      Actual results

      None of them are accepted

              rh-ee-sfaye Stanislas Faye
              ihuguet@redhat.com Inigo Huguet
              Network Management Team Network Management Team
              Vladimir Benes Vladimir Benes
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

                Created:
                Updated:
                Resolved: