-
Bug
-
Resolution: Done-Errata
-
Normal
-
rhel-9.4
-
libvirt-10.0.0-3.el9
-
None
-
Moderate
-
rhel-sst-virt-tools
-
ssg_virtualization
-
26
-
None
-
Dev ack
-
False
-
-
None
-
None
-
Pass
-
Automated
-
-
All
-
None
What were you trying to do that didn't work?
As subject
Please provide the package NVR for which bug is seen:
kernel-5.14.0-413.el9.x86_64
libvirt-10.0.0-2.el9.x86_64
qemu-kvm-8.2.0-3.el9.x86_64
How reproducible:
100%
Steps to reproduce
1. Prepare a running VM
- virsh domblklist rhel
Target Source
----------------------------------------------
vda /var/lib/libvirt/images/rhel.qcow2
- virsh list --all
Id Name State
--------------------------------
30 rhel running
2. Create snapshot with 2 branches:
- snap=s1;virsh snapshot-create-as rhel $snap --memspec /var/lib/libvirt/images/rhel_$snap
Domain snapshot s1 created
- snap=s2;virsh snapshot-create-as rhel $snap --memspec /var/lib/libvirt/images/rhel_$snap
Domain snapshot s2 created
- snap=s3;virsh snapshot-create-as rhel $snap --memspec /var/lib/libvirt/images/rhel_$snap
Domain snapshot s3 created
- virsh snapshot-revert rhel s1
Domain snapshot s1 reverted
- snap=s4;virsh snapshot-create-as rhel $snap --memspec /var/lib/libvirt/images/rhel_$snap
Domain snapshot s4 created
- snap=s5;virsh snapshot-create-as rhel $snap --memspec /var/lib/libvirt/images/rhel_$snap
Domain snapshot s5 created
- virsh snapshot-list rhel --tree
s1
+- s2+- s3
+- s4
+- s5
- virsh snapshot-current rhel --name
s5
3. Delete the parent snapshot s2
- virsh snapshot-delete rhel s2
error: Failed to delete snapshot s2
error: invalid argument: could not find base disk source in disk source chain
Expected results
Delete s2 without error
Actual results
as above
Logs and XML:
- links to
-
RHBA-2023:125049
libvirt bug fix and enhancement update
- mentioned on
[RHEL-23212] Cannot delete a parent snapshot of non-current branch
Verification test passed with libvirt-10.0.0-3.el9.x86_64 and qemu-kvm-8.2.0-6.el9.x86_64.
Thanks phrdina@redhat.com. So according to https://issues.redhat.com/browse/RHEL-23212?focusedId=24187446&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-24187446 and https://issues.redhat.com/browse/RHEL-23212?focusedId=24209212&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-24209212, move the status of preliminary testing to pass.
Pavel Hrdina
added a comment - I've created a new issue to track the new error https://issues.redhat.com/browse/RHEL-26276
Pavel Hrdina
added a comment - I've created a new issue to track the new error https://issues.redhat.com/browse/RHEL-26276 Pavel Hrdina
added a comment - Hi Meina
That is correct and all snapshots should be deleted. if you delete the snapshots in revers order s5, s4, s1 it will work but in the order you are deleting them it fails with that error.
I would say we can consider this issue resolved and track this new error in new issue.
Pavel Hrdina
added a comment - Hi Meina
That is correct and all snapshots should be deleted. if you delete the snapshots in revers order s5, s4, s1 it will work but in the order you are deleting them it fails with that error.
I would say we can consider this issue resolved and track this new error in new issue. Could you help to check the above failed issue in step 5? I think all snapshots should be deleted. Thank you very much.
# virsh snapshot-delete rhel s4
error: Failed to delete snapshot s4
error: operation failed: snapshot VM disk source and parent disk source are not the same
Preliminary Testing Version:
libvirt-10.0.0-3.el9.x86_64
qemu-kvm-8.2.0-5.el9.x86_64
Preliminary Testing Steps:
1.Prepare a running guest.
2. Create snapshots with 2 branches.
# for i in {1..3}; do virsh snapshot-create-as rhel s$i --memspec /tmp/mem.s$i; done Domain snapshot s1 created Domain snapshot s2 created Domain snapshot s3 created # virsh snapshot-revert rhel s1 Domain snapshot s1 reverted # for i in {4..5}; do virsh snapshot-create-as rhel s$i --memspec /tmp/mem.s$i; done Domain snapshot s4 created Domain snapshot s5 created # virsh snapshot-list rhel --tree s1 | +- s2 | | | +- s3 | +- s4 | +- s5
3. Delete snapshot s2.
# virsh snapshot-delete rhel s2 error: Failed to delete snapshot s2 error: unsupported configuration: deletion of non-leaf external snapshot that is not in active chain is not supported
4. Delete snapshot s3 then s2.
# virsh snapshot-delete rhel s3 Domain snapshot s3 deleted # virsh snapshot-delete rhel s2 Domain snapshot s2 deleted # virsh snapshot-list rhel --tree s1 | +- s4 | +- s5
5. Delete snapshot s1, s4, s5.
# virsh snapshot-delete rhel s1 Domain snapshot s1 deleted # virsh snapshot-delete rhel s4 error: Failed to delete snapshot s4 error: operation failed: snapshot VM disk source and parent disk source are not the same # virsh snapshot-current rhel --name s5
gitlab-bot
added a comment - Jiri Denemark mentioned this issue in a commit of Red Hat / centos-stream / rpms / libvirt on branch c9s:
libvirt-10.0.0-3.el9
gitlab-bot
added a comment - Jiri Denemark mentioned this issue in a commit of Red Hat / centos-stream / rpms / libvirt on branch c9s : libvirt-10.0.0-3.el9 gitlab-bot
added a comment - Jiri Denemark mentioned this issue in a merge request of Red Hat / centos-stream / rpms / libvirt on branch libvirt-10.0.0-3.el9:
libvirt-10.0.0-3.el9
gitlab-bot
added a comment - Jiri Denemark mentioned this issue in a merge request of Red Hat / centos-stream / rpms / libvirt on branch libvirt-10.0.0-3.el9 : libvirt-10.0.0-3.el9 Upstream commit:
commit 7143c4e1f95b4dc804f67cc5de98fba746193892
Author: Pavel Hrdina <phrdina@redhat.com>
Date: Tue Jan 30 13:05:22 2024 +0100
qemu_snapshot: fix detection if non-leaf snapshot isn't in active chain
Pavel Hrdina
added a comment - - edited Upstream commit:
commit 7143c4e1f95b4dc804f67cc5de98fba746193892
Author: Pavel Hrdina <phrdina@redhat.com>
Date: Tue Jan 30 13:05:22 2024 +0100
qemu_snapshot: fix detection if non-leaf snapshot isn't in active chain
Since the problem described in this issue should be resolved in a recent advisory, it has been closed.
For information on the advisory (Moderate: libvirt security update), and where to find the updated files, follow the link below.
If the solution does not work for you, open a new bug report.
https://access.redhat.com/errata/RHSA-2024:2236