Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-19315

Return error when setting invalid IP addresses or other properties via DBUS

    • NetworkManager-1.45.9-1.el9
    • None
    • None
    • 1
    • rhel-sst-network-management
    • ssg_networking
    • 22
    • 2
    • False
    • Hide

      None

      Show
      None
    • No
    • NMT - RHEL 8.10/9.4 DTM 14
    • Hide

      Given that a system administrator has initiated a configuration change via DBUS to update IP addresses or other properties on a daemon,
      When the administrator sends invalid IP addresses or invalid property values to the daemon,
      Then the daemon should not only log a warning but also return an error signal via DBUS to the system administrator indicating that invalid values were submitted, and no changes should be applied to the configuration.

      Definition of done:

      • The implementation meets the acceptance criteria
      • Unit tests and integration tests are written and pass
      • The code is part of a build attached to an errata
      Show
      Given that a system administrator has initiated a configuration change via DBUS to update IP addresses or other properties on a daemon, When the administrator sends invalid IP addresses or invalid property values to the daemon, Then the daemon should not only log a warning but also return an error signal via DBUS to the system administrator indicating that invalid values were submitted, and no changes should be applied to the configuration. Definition of done: The implementation meets the acceptance criteria Unit tests and integration tests are written and pass The code is part of a build attached to an errata
    • Pass
    • None
    • None

      When invalid addresses are sent to the daemon via DBUS, they are ignored with just a warning in the logs. The valid addresses are added, if there are any, and no error is signaled via DBUS, so unless the client does a paranoid verification it won't be aware of something being wrong.

      This bug has been uncovered by RHEL-1670, but inspecting the code we can see that this happens for many other properties too.

              ihuguet@redhat.com Inigo Huguet
              ihuguet@redhat.com Inigo Huguet
              Network Management Team Network Management Team
              Filip Pokryvka Filip Pokryvka
              Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

                Created:
                Updated:
                Resolved: