Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-19061

virt-v2v crashes because of off-by-one error

    • Icon: Bug Bug
    • Resolution: Done-Errata
    • Icon: Undefined Undefined
    • rhel-9.4
    • rhel-9.3.0
    • virt-v2v
    • virt-v2v-2.4.0-2.el9
    • sst_virtualization
    • ssg_virtualization
    • 22
    • False
    • Hide

      None

      Show
      None
    • All

      Virt-v2v crashes in the test suite, in this test. It doesn't always happen and it's not very easy to reproduce. It may only affect OCaml 5+ (RHEL 9 uses OCaml 4).

      $ cat tests/test-v2v-o-openstack.sh.log 
      ...
      + virt-v2v --debug-gc -i libvirt -ic test:///var/tmp/virt-v2v-2.3.7/test-data/phony-guests/guests.xml windows -o openstack -on test -oo server-id=test -oo guest-id=guestid -oo verify-server-certificate=false -oo dev-disk-by-id=test-v2v-o-openstack.d
      [   0.0] Setting up the source: -ic test:///var/tmp/virt-v2v-2.3.7/test-data/phony-guests/guests.xml -i libvirt windows
      [   1.1] Opening the source
      [  13.7] Inspecting the source
      [  15.0] Checking for sufficient free disk space in the guest
      [  15.0] Converting Microsoft Windows 7 Phony Edition to run on KVM
      virt-v2v: warning: QEMU Guest Agent MSI not found on tools ISO/directory. You may want to install the guest agent manually after conversion.
      Fatal error: allocation failure during minor GC
      ./test-v2v-o-openstack.sh: line 64: 2328563 Aborted                 (core dumped) $VG virt-v2v --debug-gc -i libvirt -ic "$libvirt_uri" windows -o openstack -on test -oo server-id=test -oo guest-id=guestid -oo verify-server-certificate=false -oo dev-disk-by-id=$d
      

      I tracked this down to a genuine off-by-one bug in virt-v2v. We are writing 7 elements to a 6 element array. The fix is:

      https://github.com/libguestfs/libguestfs-common/commit/0dba002c20b1ff4046f45fc51528ee199a20706c

      I think we should include the fix in RHEL 9.4, even if this bug isn't reproducible easily.
       
       
       

       

            rhn-eng-rjones Richard Jones
            rhn-eng-rjones Richard Jones
            virt-maint virt-maint
            Ming Xie Ming Xie
            Votes:
            0 Vote for this issue
            Watchers:
            11 Start watching this issue

              Created:
              Updated:
              Resolved: