Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-147456

Better handle unexpected file in /etc/NetworkManager/system-connection when performing leapp upgrade

Linking RHIVOS CVEs to...Migration: Automation ...Sync from "Extern...XMLWordPrintable

    • None
    • None
    • rhel-upgrades
    • 1
    • False
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • None
    • None
    • Unspecified
    • Unspecified
    • Unspecified
    • None

      What were you trying to do that didn't work?

      To facilitate my other tests, I executed git init in `/etc/NetworkManager/system-connections` to track nm connection files. However, the existence of .git prevented the leapp upgrade. After deleting .git, the upgrade proceeded smoothly.

       

      Although having a .git file in that directory is not a normal operation, if leapp could provide clearer error messages, people would be able to take actions easily

      What is the impact of this issue to you?

      I cannot upgrade, and the leapp report is not clear enough 

      Please provide the package NVR for which the bug is seen:

      How reproducible is this bug?:

      100%

      Steps to reproduce

      1. find a beaker system, install RHEL-8.10
      2. run `git init` in  `/etc/NetworkManager/system-connections` 
      3. perform leapp upgrade (I'm using this script https://gitlab.cee.redhat.com/kernel-qe/kernel/-/blob/master/networking/nic/functions/update_via_leapp/runtest.sh?ref_type=heads , `ORIGIN_VERSION=8.10 TARGET_VERSION=9.8 bash runtest.sh`)

      Expected results

      Show more clear error message

      Actual results

      Got this message

       

      [15:50:44@wsfd-advnetlab127 update_via_leapp]0# cat /var/log/leapp/leapp-report.txt
      Risk Factor: high (error)
      Title: Actor network_manager_connection_scanner unexpectedly terminated with exit code: 1
      Summary: Traceback (most recent call last):
        File "/usr/lib/python3.6/site-packages/leapp//actor_definition.py", line 75, in _do_run
          actor_instance.run(*args, **kwargs)
        File "/usr/lib/python3.6/site-packages/leapp/actors/__init__.py", line 319, in run
          self.process(*args)
        File "/etc/leapp/repos.d/system_upgrade/el8toel9/actors/networkmanagerconnectionscanner/actor.py", line 18, in process
          networkmanagerconnectionscanner.process()
        File "/etc/leapp/repos.d/system_upgrade/el8toel9/actors/networkmanagerconnectionscanner/libraries/networkmanagerconnectionscanner.py", line 60, in process
          process_dir(NM_CONN_DIR)
        File "/etc/leapp/repos.d/system_upgrade/el8toel9/actors/networkmanagerconnectionscanner/libraries/networkmanagerconnectionscanner.py", line 55, in process_dir
          process_file(os.path.join(NM_CONN_DIR, f))
        File "/etc/leapp/repos.d/system_upgrade/el8toel9/actors/networkmanagerconnectionscanner/libraries/networkmanagerconnectionscanner.py", line 29, in process_file
          keyfile.load_from_file(filename, GLib.KeyFileFlags.NONE)
      GLib.GError: g-key-file-error-quark: Not a regular file (1)
      Key: 688719a7a60eebeea4ac938a1fffcb5ac7e78617
      ----------------------------------------
      

       

              leapp-notifications leapp-notifications
              rh-ee-mshi1 Mingyu Shi
              leapp-notifications leapp-notifications
              RHEL Upgrades QE Team RHEL Upgrades QE Team
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated: