Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-1441

[RFE] Support changing the eswitch mode

XMLWordPrintable

    • NetworkManager-1.46.0-1.el9
    • Medium
    • 1
    • rhel-sst-network-management
    • ssg_networking
    • 26
    • 2
    • False
    • Hide

      None

      Show
      None
    • Yes
    • NMT - Last NMT changes
    • Hide

      User story
      As a NM user, I want to select the eswitch mode between legacy SRIOV and switchdev.

      Acceptance criteria

      Given a NIC that supports devlink and switchdev mode

      When a NM profile contains the sriov.eswitch-mode property "legacy" or "switchdev"
      Then NM changes the eswitch mode to the requested value just before creating the VFs

      When NM has to change the eswitch mode and the current number of VFs is not 0
      Then change the number of VFs to 0 to avoid errors when setting the eswitch mode, then continue as normal

      Definition of Done

      • The implementation meets the acceptance criteria
      • Unit tests and integration tests if applicable (decided during refinement) are written and passed
      • DocText/DocType is set.
      • The code is part of a downstream build attached to an errata
      Show
      User story As a NM user, I want to select the eswitch mode between legacy SRIOV and switchdev. Acceptance criteria Given a NIC that supports devlink and switchdev mode When a NM profile contains the sriov.eswitch-mode property "legacy" or "switchdev" Then NM changes the eswitch mode to the requested value just before creating the VFs When NM has to change the eswitch mode and the current number of VFs is not 0 Then change the number of VFs to 0 to avoid errors when setting the eswitch mode, then continue as normal Definition of Done The implementation meets the acceptance criteria Unit tests and integration tests if applicable (decided during refinement) are written and passed DocText/DocType is set. The code is part of a downstream build attached to an errata
    • Pass
    • None
    • Enhancement
    • Hide
      .NetworkManager now supports configuring the `switchdev` mode for advanced hardware offload

      With this enhancement, you can configure the following new properties in NetworkManager connection profiles:

      * `sriov.eswitch-mode`
      * `sriov.eswitch-inline-mode`
      * `sriov.eswitch-encap-mode`

      With these properties, you can configure the eSwitch of smart network interface controllers (Smart NICs). For example, use the `sriov.eswitch-mode` setting to change the mode from `legacy SR-IOV` to `switchdev` to use advanced hardware offload features.
      Show
      .NetworkManager now supports configuring the `switchdev` mode for advanced hardware offload With this enhancement, you can configure the following new properties in NetworkManager connection profiles: * `sriov.eswitch-mode` * `sriov.eswitch-inline-mode` * `sriov.eswitch-encap-mode` With these properties, you can configure the eSwitch of smart network interface controllers (Smart NICs). For example, use the `sriov.eswitch-mode` setting to change the mode from `legacy SR-IOV` to `switchdev` to use advanced hardware offload features.
    • Done
    • None

      Description of problem:

      OpenStack team is expecting NetworkManager provide support of
      OVS SR-IOV TC Hardware Offload describe in

      https://docs.openstack.org/neutron/queens/admin/config-ovs-offload.html

      Version-Release number of selected component (if applicable):

      How reproducible:

      Steps to Reproduce:
      1.
      2.
      3.

      Actual results:

      Expected results:

      Additional info:

      User story
      As an OpenStack administrator using RHEL 9.4+, I want NetworkManager to provide support for OpenvSwitch (OVS) SR-IOV Traffic Control (TC) Hardware Offload configuration, so that I can leverage hardware offload capabilities for increased network performance.

      Acceptance criteria
      Given a OpenStack system based on RHEL 9.4+,
      When user apply nmstate YML containing OpenvSwitch TC hardware offloading config,
      Then nmstate will instruct NetworkManager to setup the OVS TC hardware offload describe in https://docs.openstack.org/neutron/queens/admin/config-ovs-offload.html

      Definition of Done

      • The implementation meets the acceptance criteria
      • Unit tests and integration tests if applicable (decided during refinement) are written and passed
      • DocText/DocType is set.
      • The code is part of a downstream build attached to an errata

            [RHEL-1441] [RFE] Support changing the eswitch mode

            Errata Tool added a comment -

            Since the problem described in this issue should be resolved in a recent advisory, it has been closed.

            For information on the advisory (NetworkManager bug fix and enhancement update), and where to find the updated files, follow the link below.

            If the solution does not work for you, open a new bug report.
            https://access.redhat.com/errata/RHBA-2024:2395

            Errata Tool added a comment - Since the problem described in this issue should be resolved in a recent advisory, it has been closed. For information on the advisory (NetworkManager bug fix and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2024:2395

            Filip Hanzelka added a comment -

            Peer review done in https://docs.google.com/document/d/1bFC-qbX9nmDBsdRC0cnPjq4PNRCnGCc7ZPtfYTeoXII/edit

            Filip Hanzelka added a comment - Peer review done in https://docs.google.com/document/d/1bFC-qbX9nmDBsdRC0cnPjq4PNRCnGCc7ZPtfYTeoXII/edit

            Marc Muehlfeld added a comment - - edited

            fhanzelk , can you please peer review the RN for this ticket? Thanks.

            Marc Muehlfeld added a comment - - edited fhanzelk , can you please peer review the RN for this ticket? Thanks.

            Inigo Huguet added a comment -

            you can configure the eSwitch mode of smart network interface controllers.

            Apart from that, LGTM.

            Inigo Huguet added a comment - you can configure the eSwitch mode of smart network interface controllers. Apart from that, LGTM.

            Marc Muehlfeld added a comment -

            ihuguet@redhat.com , I updated the release note based on your suggestion. Can you please check it again? Thanks.

            Marc Muehlfeld added a comment - ihuguet@redhat.com , I updated the release note based on your suggestion. Can you please check it again? Thanks.

            Inigo Huguet added a comment -

            mmuehlfe@redhat.com I see it mostly fine. However, I miss a more general explanation of what those properties does: configuring the NIC's eswitch. The main usage is to set the switchdev mode, but not only. May I suggest changing the last paragraph to something like:

            > These properties allow to configure the NIC hardware's eswitch. For example, use them to change from `legacy SR-IOV` to `switchdev` mode on smart network interface controllers (Smart NICs) to use advanced hardware offload features. 

            Inigo Huguet added a comment - mmuehlfe@redhat.com I see it mostly fine. However, I miss a more general explanation of what those properties does: configuring the NIC's eswitch. The main usage is to set the switchdev mode, but not only. May I suggest changing the last paragraph to something like: > These properties allow to configure the NIC hardware's eswitch. For example, use them to change from `legacy SR-IOV` to `switchdev` mode on smart network interface controllers (Smart NICs) to use advanced hardware offload features. 

            Marc Muehlfeld added a comment -

            ihuguet@redhat.com , can you please review the release note draft (see Documentation tab)? Thanks.

            Marc Muehlfeld added a comment - ihuguet@redhat.com , can you please review the release note draft (see Documentation tab)? Thanks.

            Inigo Huguet added a comment -

            mmuehlfe@redhat.com The request was done by OpenStack to use OVS, but the feature (configuring switchdev mode from NetworkManager) is more generic and can have more uses other than OVS.

            Don't pay attention to the initial description and look at Development>acceptance criteria and Documentation>RN text. If you still have doubts, do not hesitate to ask again here or in Slack.

            Inigo Huguet added a comment - mmuehlfe@redhat.com The request was done by OpenStack to use OVS, but the feature (configuring switchdev mode from NetworkManager) is more generic and can have more uses other than OVS. Don't pay attention to the initial description and look at Development>acceptance criteria and Documentation>RN text. If you still have doubts, do not hesitate to ask again here or in Slack.

            Marc Muehlfeld added a comment -

            ihuguet@redhat.com , this ticket is flagged to get a release note in RHEL 9.4 but, as far as I know, OVS isn't supported in plain RHEL (only in layered products).

            Can you confirm that this is really a feature that we support in RHEL?

            Marc Muehlfeld added a comment - ihuguet@redhat.com , this ticket is flagged to get a release note in RHEL 9.4 but, as far as I know, OVS isn't supported in plain RHEL (only in layered products). Can you confirm that this is really a feature that we support in RHEL?

            sync bot added a comment -

            An attempt was made to sync this Jira Issue to quality engineering's test management system as a product requirement work item to be verified by Quality Engineering.

            The user defined as the QA Contact, 'vbenes', does not exist in the target test management system project, 'RHEL Kernel Networking'. For more information: QA Contact

            This allows Quality Engineering to provide traceability to the testing assets that cover verification of the new functionality. It allows stakeholders visibility into the test approach, test coverage and execution results. For more information about this sync utility please see: Product Requirements Synchronization Jira to Polarion.

            sync bot added a comment - An attempt was made to sync this Jira Issue to quality engineering's test management system as a product requirement work item to be verified by Quality Engineering. The user defined as the QA Contact, 'vbenes', does not exist in the target test management system project, 'RHEL Kernel Networking'. For more information: QA Contact This allows Quality Engineering to provide traceability to the testing assets that cover verification of the new functionality. It allows stakeholders visibility into the test approach, test coverage and execution results. For more information about this sync utility please see: Product Requirements Synchronization Jira to Polarion .

              ihuguet@redhat.com Inigo Huguet
              fge@redhat.com Gris Ge
              Inigo Huguet Inigo Huguet
              Vladimir Benes Vladimir Benes
              Marc Muehlfeld Marc Muehlfeld
              Votes:
              0 Vote for this issue
              Watchers:
              19 Start watching this issue

                Created:
                Updated:
                Resolved: