Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-1408

Rollback deactivated some ovs interfaces

XMLWordPrintable

    • None
    • Moderate
    • sst_network_management
    • ssg_networking
    • 5
    • False
    • Hide

      None

      Show
      None
    • No
    • None
    • Hide

      Given a system administrator using nmstate and configuring ovs interfaces as detailed in the ticket description
      When the system administrator applies a change to the mtu to 2000 using the --no-commit flag,  and subsequently allow the applied state to rollback due to a timeout,

      Then the state of all ovs interfaces should be rolled back to their previous state without any changes or deactivations and no ovs interfaces should be removed or partially removed.

      Definition of Done

      • The implementation meets the acceptance criteria
      • The unit tests and integration tests are written and passed
      • The code is part of a build attached to an errata
      Show
      Given a system administrator using nmstate and configuring ovs interfaces as detailed in the ticket description When the system administrator applies a change to the mtu to 2000 using the --no-commit flag,  and subsequently allow the applied state to rollback due to a timeout, Then the state of all ovs interfaces should be rolled back to their previous state without any changes or deactivations and no ovs interfaces should be removed or partially removed. Definition of Done The implementation meets the acceptance criteria The unit tests and integration tests are written and passed The code is part of a build attached to an errata
    • None
    • None
    • If docs needed, set a value
    • None

      Description of problem:
      Applied a state without commit, after rollback on timeout,some ovs interfaces were deactivated.

      Version-Release number of selected component (if applicable):
      nmstate-2.2.8-0.bz2156386.el9_2.x86_64
      nispor-1.2.10-1.el9.x86_64
      NetworkManager-1.42.2-1.el9.x86_64
      openvswitch2.15-2.15.0-81.el9fdp.x86_64
      DISTRO=RHEL-9.2.0-20230319.13

      How reproducible:
      100%

      Steps to Reproduce:
      echo "
      interfaces:

      • name: ovsbr0
        type: ovs-bridge
        state: up
        bridge:
        options:
        datapath: netdev
        port:
      • name: ovs0
      • name: dpdkbond0
        link-aggregation:
        mode: balance-slb
        port:
      • name: dpdk0
      • name: dpdk1
      • name: dpdk0
        type: ovs-interface
        state: up
        dpdk:
        devargs: 0000:3b:00.0
        n_rxq: 100
        n_rxq_desc: 1024
        n_txq_desc: 2048
        mtu: 3000
      • name: dpdk1
        type: ovs-interface
        state: up
        dpdk:
        devargs: 0000:3b:00.1
        rx-queue: 100
        n_rxq_desc: 1024
        n_txq_desc: 2048
        mtu: 3000
      • name: ovs0
        type: ovs-interface
        state: up
        " | nmstatectl apply
      1. change mtu to 2000 with --no-commit
        echo "
        —
        interfaces:
      • name: ovsbr0
        type: ovs-bridge
        state: up
        bridge:
        options:
        datapath: netdev
        port:
      • name: ovs0
      • name: dpdkbond0
        link-aggregation:
        mode: balance-slb
        port:
      • name: dpdk0
      • name: dpdk1
      • name: dpdk0
        type: ovs-interface
        state: up
        dpdk:
        devargs: 0000:3b:00.0
        n_rxq: 100
        n_rxq_desc: 1024
        n_txq_desc: 2048
        mtu: 2000
      • name: dpdk1
        type: ovs-interface
        state: up
        dpdk:
        devargs: 0000:3b:00.1
        rx-queue: 100
        n_rxq_desc: 1024
        n_txq_desc: 2048
        mtu: 2000
      • name: ovs0
        type: ovs-interface
        state: up
        " | nmstatectl apply --no-commit --timeout 10
        sleep 15
        ovs-vsctl show
        nmcli con

      Actual results:
      Some ovs interfaces were removed after rollback
      According to my test, the rollback result may vary, sometimes partially and sometimes all removed. In this attachment, it removed all

      Expected results:
      Rollback to the previous state without any changes

      Additional info:
      Test with i40e card on dell-per740-80.rhts.eng.pek2.redhat.com

            rh-ee-sfaye Stanislas Faye
            rh-ee-mshi1 Mingyu Shi
            Network Management Team Network Management Team
            Mingyu Shi Mingyu Shi
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated: