Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-137388

Add riscv64 to valgrind_arches on CentOS Stream 10 / RHEL 10

Linking RHIVOS CVEs to...Migration: Automation ...SWIFT: POC ConversionSync from "Extern...XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • CentOS Stream 10, rhel-10.2
    • redhat-rpm-config
    • None
    • None
    • None
    • rhel-swm
    • None
    • False
    • False
    • Hide

      None

      Show
      None
    • None
    • Red Hat Enterprise Linux
    • None
    • None
    • None
    • Unspecified
    • Unspecified
    • Unspecified
    • None

      Some packages require valgrind related packages for tests. However, since version 3.25.1, valgrind can be built on riscv64, which means valgrind_arches should be able to have riscv64 added to its list. Some packages may FTBFS without valgrind or proper logic around valgrind_arches throughout a spec file.

      What were you trying to do that didn't work?

      A recent package build of fwupd (2.0.19) fails on riscv64 due to valgrind packages not being installed. This is because valgrind_arches is missing riscv64.

      What is the impact of this issue to you?

      Packages that are not properly accounting for valgrind_arches in %build and %check will fail on riscv64, even if accounted for in BuildRequires. fwupd so far is the only one found to be affected. However, if valgrind is installed into the build root for fwupd on riscv64, the build and tests complete successfully.

      As such, this is very small impact.

      Please provide the package NVR for which the bug is seen:

      redhat-rpm-config-293-1.el10

      How reproducible is this bug?:

      Always

      Steps to reproduce

      1. Install mock on a given riscv64 system
      2. Configure mock against the proper build root
      3. mock -r cfg fwupd-2.0.19-1.el10.src.rpm

      Expected results

      Successful build

      Actual results

      This fails with the following.

      ```
      Run-time dependency valgrind found: NO (tried pkgconfig)
      ```

      And at the end

      ```
      Run-time dependency valgrind found: NO (tried pkgconfig)
      meson.build:378:11: ERROR: Dependency "valgrind" not found, tried pkgconfig
      A full log can be found at /builddir/build/BUILD/fwupd-2.0.19/redhat-linux-build/meson-logs/meson-log.txt
      error: Bad exit status from /var/tmp/rpm-tmp.bLXttp (%build)
      Bad exit status from /var/tmp/rpm-tmp.bLXttp (%build)
      RPM build errors:
      Child return code was: 1
      ```

      Other packages that rely on valgrind_arches may or may not have a similar issue. However, as valgrind is now buildable on riscv64, it should be able to be safely added to the list.

              fweimer@redhat.com Florian Weimer
              louis.abel Louis Abel
              packaging-team-maint packaging-team-maint
              Software Management QE Software Management QE
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated: