Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-115833

Refactor the targetuserspacecreator actor

Linking RHIVOS CVEs to...Migration: Automation ...SWIFT: POC ConversionSync from "Extern...XMLWordPrintable

    • rhel-upgrades
    • 12
    • 0
    • False
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • None
    • None
    • Undefined
    • Unspecified
    • Unspecified
    • Unspecified
    • None

      The actor is now in really messy state. For non-authors, heavy to read. Kind of complex. Hard to cover by tests, .... and hard to extend. Currently we are going to propose some additional temproary ugly hacks because of the shape of this actor. As it is one of the most fundamental actors, the code & design of the actor should correspond to that fact as well. Another development related to this part of upgrade could be negatively affected without the proper housekeeping.

      We should start work on that after all work on the current (7.9 -> 8.2) release is done, and ideally after the task focused on customers (affect containers & initramdisks) is done, so we will need just one refactoring instead of two).

      UPDATE: This is coming back each couple of months and now, especially when working on distro-agnostic solution, number of RHUI related stuff, and also it's make everything significantly harder when working on upgrades+conversion in one go. We should finally deal with this technical debt as it's making our lives significantly harder. The userspacegen library must be split into several libs / python modules and most functions needs to be rewritten to clean the design.

      AC:

      • actor is rewritten properly (this is fuzzy AC that is not measurable..) to follow the clean code practices
      • the code is covered by unit tests

              leapp-notifications leapp-notifications
              pstodulk@redhat.com Petr Stodulka
              leapp-notifications leapp-notifications
              RHEL Upgrades QE Team RHEL Upgrades QE Team
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Created:
                Updated: