Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-108161

Add monkeytype type rewriters to configuration to rewrite hidden types to public types

Linking RHIVOS CVEs to...Migration: Automation ...Sync from "Extern...XMLWordPrintable

    • Icon: Story Story
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • None
    • stratis-cli
    • None
    • None
    • None
    • False
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • None
    • None
    • Unspecified
    • Unspecified
    • Unspecified
    • None

      Goal

      • As a developer, I want to have more files that are repeatably and correctly annotated. In particular, I want to make sure that the types that monkeytype adds are public types, not hidden types. monkeytype does type inference dynamically and it may use the fully qualified name of a type, even if that type is in a hidden module but re-exported from a public module.

      Acceptance criteria

      • Where there is a non-hidden type name for a fully qualified type name in an external library that uses a hidden module, the annotation step should always use the non-hidden name.
      • All files that are not currently annotated in stratis-cli solely because they would be annotated with type names in hidden modules are now automatically annotated (which in practice means being added to a variable in the Makefile).

              amulhern@redhat.com the Mulhern
              amulhern@redhat.com the Mulhern
              stratis-team stratis-team
              Filip Suba Filip Suba
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Created:
                Updated: