Please provide the package NVR for which the bug is seen:
rsync-3.2.5-3.el9
rsync-3.4.1-2.el10
How reproducible is this bug?:
Always
Steps to reproduce
- Configure ssh key with password
- set SSH_ASKPASS script that provides
- attempt rsync
Expected results
rsync works
Actual results
rsync fails with remote ssh returing
Permission denied, please try again
------
The issue is caused by the upstream change prompted by Red Hat kludging fixes for DBus issues.
Hanging rsync because of ssh issue with D-Bus
https://github.com/RsyncProject/rsync/issues/176
with Commit a6bdf31
released in upstream v3.2.4 and inherited by RH rebase to v3.2.5 to incorporate CVE fixes
RHEL10 was simply based off a later version that continues to inherit this problem.
In clearing the DISPLAY variable immediately on startup this break all the condition checking in ssh related to SSH_ASKPASS.
At a bare minimum the clearing of DISPLAY should only be done if the SSH_ASKPASS environment variable is not set.
rsync has no a-priori knowledge of the possible use of DISPLAY or any other environment variable that does not directly control it and should not be unilaterally changing things it knows nothing about.