Uploaded image for project: 'RHEL'
  1. RHEL
  2. RHEL-104346

netkvm: avoid sending 4095 VLAN requests in default Advanced

Linking RHIVOS CVEs to...Migration: Automation ...SWIFT: POC ConversionSync from "Extern...XMLWordPrintable

    • [virtio-win] netkvm: avoid sending 4095 VLAN requests in default Advanced
    • Red Hat Enterprise Linux
    • 100% To Do, 0% In Progress, 0% Done
    • rhel-virt-windows
    • False
    • Hide

      None

      Show
      None
    • QE ack
    • Unspecified
    • Unspecified
    • Unspecified
    • x86_64
    • Windows

      Goal

      • Avoid excessive VLAN configuration in default driver setup to reduce CPU overhead and prevent fallback to inefficient RX modes on the device.

      Current State

      • When the driver negotiates the VLAN feature and the user does not explicitly configure it ("Priority and VLAN tagging" = All by default), the Windows NetKVM driver sends 4095 VLAN ADD requests during initialization.

      This leads to two spec-described issues:

      “…it can use a hash filter or silently switch to allmulti or promiscuous mode if it is given too many addresses.”
      — Virtio Spec v1.2-cs01, Section 5.1.3.2
      
      "Similar to the MAC address based filtering, the VLAN filtering is also best-effort: unwanted packets could still arrive.”
      — Virtio Spec v1.2-cs01, Section 5.1.3.3
      
      Refer: https://docs.oasis-open.org/virtio/virtio/v1.3/csd01/virtio-v1.3-csd01.html#fn12x5-bk

      As a result, the device may stop filtering properly, and the OS ends up handling unwanted packets, increasing CPU load. 

      This behavior is functionally equivalent to not negotiating the VLAN feature at all, and differs from the Linux driver, which only configures VLANs when explicitly requested.

       

      Recommendation

      • Do not send VLAN ADD requests unless the user explicitly configures VLANs.
      • Align behavior with Linux driver.
      • Reconfirm MS certification requirements, but avoid inefficient default behavior.

      Refer: https://github.com/virtio-win/kvm-guest-drivers-windows/issues/1392

              ybendito@redhat.com Yuri Benditovich
              rh-ee-wji Wenkang Ji
              Virt Windows SST Bugs Virt Windows SST Bugs
              Wenkang Ji Wenkang Ji
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated: