Motivation:

• The normal war must be deployable on a vanilla EAP (or even WildFly) without modification of that EAP or that war file. It should be easy to try out.
• The openshift war must support system properties to be configured specifically to mysql or postgrsql, one of which can only be set in "jta-data-source" in persistence.xml , which means we need to turn on EAP's system property replacement, and therefore EAP isn't vanilla any more.

Implementation:

• A normal product build does "mvn clean install -Dproductized"
• The openshift product build must do "mvn clean install -Dproductized -DproductizedOpenshift"

The downside is that we'll have 2 builds...

In an ideal world, we'd find a way to set "jta-data-source" dynamically from a system property without messing with the persistence.xml nor the EAP config change. I am looking into that, but it doesn't seem to be any such approach. See my mail to sme-eap.

Proposal B

In a productized build, we always use the openshift variant of the persistence.xml (that doesn't work on vanilla wildfly). The productized zip only contains the sources, not the war file.