Uploaded image for project: 'Red Hat Developer Hub Bugs'
  1. Red Hat Developer Hub Bugs
  2. RHDHBUGS-736

Improve output of install-dynamic-plugins.py

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • None
    • Dynamic Plugins
    • None
    • 2
    • False
    • Hide

      None

      Show
      None
    • False

      Description of problem:

      When something goes wrong with installing a dynamic plugin from an oci artifact, we could improve the output to better examine the error.

      plugins:
        - package: oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/dynatrace-backstage-plugin-dql-backend:pr_791__2.2.0!dynatrace-backstage-plugin-dql-backend
          disabled: false
      
      ==> Copying image oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/dynatrace-backstage-plugin-dql-backend:pr_791__2.2.0 to local filesystem
      165
      Getting image source signatures
      166
      Copying blob sha256:2ade1db7ba0d55862020d4fd650430775f8645ec13bc90091eeb97f52dd011f8
      167
      Copying config sha256:60c9a7f56fdb2552edb57a471d6e19d73c88195f4b37fe7f51ba0f11096a3fd2
      168
      Writing manifest to image destination
      169
      Traceback (most recent call last):
      170
      File "/opt/app-root/src/install-dynamic-plugins.py", line 429, in <module>
      171
      main()
      172
      File "/opt/app-root/src/install-dynamic-plugins.py", line 405, in main
      173
      with open(hash_file_path, 'w') as hash_file:
      174
      FileNotFoundError: [Errno 2] No such file or directory: '/dynamic-plugins-root/dynatrace-backstage-plugin-dql-backend/dynamic-plugin-config.hash'
      

      In the above case, the install fails, because the path specified after the `!` is not present in the oci image. The correct path would've been dynatrace-backstage-plugin-dql-backend-dynamic
      If the install fails, like above, it would be good to catch that error and

      • list the directories available in the oci image
      • print the target directory where the plugin would be installed locally
      • maybe additional data that makes debugging the error easier

              Unassigned Unassigned
              rh-ee-mhild Marcel Hild
              RHDH Cope
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated: