-
Bug
-
Resolution: Unresolved
-
Major
-
1.10.0
-
1
-
False
-
-
False
-
-
-
RHDH Install 3287
Description of problem:
When a workspace provides its own tests/config/dynamic-plugins.yaml, the e2e test framework does not replace local plugin package paths (e.g., ./dynamic-plugins/dist/...) with OCI references during PR builds. This causes PR validation tests in OpenShift CI to deploy plugins from local paths instead of the PR-built OCI images, resulting in test failures.
Workspaces without a user-provided dynamic-plugins.yaml are unaffected because they go through a separate auto-generation code path that correctly handles OCI replacement.
Steps to Reproduce
Create a workspace with an e2e-tests/tests/config/dynamic-plugins.yaml file listing plugins with local paths
Open a PR against the overlay repo that modifies this workspace
Observe that the OpenShift CI test deploys with local paths instead of OCI references
Actual results:
The dynamic plugins config deployed to the cluster contains local paths:
plugins:
** package: ./dynamic-plugins/dist/plugin-name
Expected results:
For PR builds, plugin package paths should be replaced with OCI URLs pointing to the PR-built images:
plugins: ** package: oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/plugin-name:pr_1946__1.8.2!plugin-name
Root cause:
Two issues:
- The loadAndInjectPluginMetadata() function (used when a user config exists) only injected pluginConfig from metadata but never performed OCI URL replacement. OCI replacement only existed in the generateDynamicPluginsConfigFromMetadata() code path (used when no user config exists).
- The OpenShift CI step script did not export GIT_PR_NUMBER, so the environment variable was not visible to the test process.