Uploaded image for project: 'Red Hat Developer Hub Bugs'
  1. Red Hat Developer Hub Bugs
  2. RHDHBUGS-2408

Can't resolve 'react-dom' in various plugin builds - add missing peer or dev deps?

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Blocker Blocker
    • 1.9.0
    • 1.9.0
    • Build, Dynamic Plugins
    • None
    • RHDH COPE 3284, RHDH COPE 3285, RHDH COPE 3286

      Description of problem:

      1 or more plugin builds have started failing recently due to missing react-dom dependency in their package.json / yarn.lock:

      Errors  Files
     1  plugins/dynamic-home-page/src/components/EntitySection/EntityCard.test.tsx:19
     1  plugins/dynamic-home-page/src/components/OnboardingSection/OnboardingCard.test.tsx:18
     2  plugins/dynamic-home-page/src/components/OnboardingSection/OnboardingCard.tsx:17
     1  plugins/dynamic-home-page/src/components/SearchBar.tsx:18
     1  plugins/dynamic-home-page/src/components/TemplateSection/TemplateCard.test.tsx:17

...

    Module not found: Error: Can't resolve 'react-dom' in '/var/workdir/source/workspaces/homepage/node_modules/@backstage/core-components/dist/components/FeatureDiscovery'

      – https://konflux-ui.apps.stone-prod-p02.hjvn.p1.openshiftapps.com/ns/rhdh-tenant/applications/rhdh-plugin-catalog-1/pipelineruns/rhdh-bsp-dynamic-home-page-1-on-push-z5xmb/logs

      May be caused by changes I'm trying in RHIDP-9067 and RHIDP-10979

      May need a global patch to includfe "react-dom": "^18" when we also include "@types/react-dom": "^18".

      Several workspaces include types/react-dom as RESOLUTIONS but not react-dom itself as a peerdep or devdep.

              nickboldt Nick Boldt
              nickboldt Nick Boldt
              RHDH Cope
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: