-
Bug
-
Resolution: Unresolved
-
Undefined
-
None
-
1.7.0, 1.7.1, 1.7.2, 1.8.0
-
None
-
False
-
-
False
-
-
Description of problem:
Starting RHDH with a malformed entry in the "plugins" array in the dynamic plugin config results in a stack trace being printed, instead of a helpful validation failure.
Prerequisites (if any, like setup, operators/versions):
RHDH 1.7 via Helm
Steps to Reproduce
Create a dynamic plugins config with a malformed entry, e.g this one with the missing "package"
plugins:
- disabled: false
package: ./dynamic-plugins/dist/backstage-community-plugin-redhat-argocd - disabled: false
Actual results:
======= Overriding dynamic plugin configuration ./dynamic-plugins/dist/backstage-plugin-notifications-backend-dynamic
======= Overriding dynamic plugin configuration ./dynamic-plugins/dist/backstage-plugin-signals-backend-dynamic
Traceback (most recent call last):
File "/opt/app-root/src/install-dynamic-plugins.py", line 658, in <module>
main()
File "/opt/app-root/src/install-dynamic-plugins.py", line 615, in main
mergePlugin(plugin, allPlugins, dynamicPluginsFile)
File "/opt/app-root/src/install-dynamic-plugins.py", line 458, in mergePlugin
package = plugin['package']
~~~~~~^^^^^^^^^^^
KeyError: 'package'
======= Removed lock file: /dynamic-plugins-root/install-dynamic-plugins.lock
Expected results:
A better validation error, e.g "entry in the 'plugins' array is malformed: missing 'package' key'
Reproducibility (Always/Intermittent/Only Once):
Always
Build Details:
RHDH 1.7