-
Bug
-
Resolution: Done
-
Critical
-
1.8.0
-
None
-
1
-
False
-
-
False
-
Release Note Not Required
-
-
-
RHDH F&UI plugins 3281
Description of problem:
https://github.com/redhat-developer/rhdh-plugins/pull/1266#pullrequestreview-3310848245
The PR introduced two dependencies which I think we should double-check:
@roadiehq/scaffolder-backend-module-utils
Is this really needed? I think its fine to have it, but at the same moment, I think our default template should not depend on this, right?
@ai-zen/node-fetch-event-source
Is there a reason that we use this instead of @microsoft/fetch-event-source?
https://www.npmjs.com/package/@ai-zen/node-fetch-event-source refers https://github.com/ai-zen/node-fetch-event-source which is a 5 year old fork of https://github.com/Azure/fetch-event-source
And actually Backstage is using the one from the microsoft org in @backstage/scaffolder-common directly.
As first step I suggest that we switch to the microsoft dependency.
I guess at the end we could also use ScaffolderClient. I will fork this issue to take a look into this option which would make the plugin more stable against changes in the scaffolder API.
- is cloned by
-
RHDHBUGS-2111 Bulk import scaffolder support: use scaffolder client instead of custom fetch code
-
- New
-