Uploaded image for project: 'Red Hat Developer Hub Bugs'
  1. Red Hat Developer Hub Bugs
  2. RHDHBUGS-2110

Bulk import scaffolder support: fix dependencies

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Critical Critical
    • 1.8.0
    • 1.8.0
    • Bulk Import
    • None
    • RHDH F&UI plugins 3281

      Description of problem:

      https://github.com/redhat-developer/rhdh-plugins/pull/1266#pullrequestreview-3310848245

      The PR introduced two dependencies which I think we should double-check:

      @roadiehq/scaffolder-backend-module-utils
      Is this really needed? I think its fine to have it, but at the same moment, I think our default template should not depend on this, right?

      @ai-zen/node-fetch-event-source
      Is there a reason that we use this instead of @microsoft/fetch-event-source?

      https://www.npmjs.com/package/@ai-zen/node-fetch-event-source refers https://github.com/ai-zen/node-fetch-event-source which is a 5 year old fork of https://github.com/Azure/fetch-event-source

      And actually Backstage is using the one from the microsoft org in @backstage/scaffolder-common directly.

      As first step I suggest that we switch to the microsoft dependency.

      I guess at the end we could also use ScaffolderClient. I will fork this issue to take a look into this option which would make the plugin more stable against changes in the scaffolder API.

              cjerolim Christoph Jerolimov
              cjerolim Christoph Jerolimov
              RHIDP - Frontend Plugins & UI
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: