Uploaded image for project: 'Red Hat Developer Hub Bugs'
  1. Red Hat Developer Hub Bugs
  2. RHDHBUGS-1768

GitHub available on the sign-in page by default with no GitHub auth provider configured

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Not a Bug
    • Icon: Normal Normal
    • None
    • None
    • Authentication
    • 3
    • False
    • Hide

      None

      Show
      None
    • False
    • RHDH Core Team 3257, RHDH Core Team 3258, RHDH F&UI plugins 3259, RHDH F&UI plugins 3260

      Description of the problem:
      The GitHub Sign In card is always shown regardless of the auth configuration in backstage, giving the impression to the user that it is possible to login to GitHub as an alternative method. However, when clicking the link, a popup is opened with a JSON error:

      {"error":{"name":"NotFoundError","message":"No auth provider registered for 'github'"},"request":{"method":"GET","url":"/api/auth/github/start?scope=read%3Auser&origin=https%3A%2F%2Fbackstage-backstage-rhdh-operator.apps.stress.parodos.dev&flow=popup&env=development"},"response":{"statusCode":404}} 
      

      **

      How reproducible:

      All the time.

      Steps to reproduce:

      1. Configure RHDH without providing GITHUB_TOKEN and GITHUB_CLIENT_ID and GITHUB_CLIENT_SECRET values in the secret.
      2. Restart the backstage pod and wait for it to reach Ready status.
      3. Open a browser and load the landing page.
      4. Click on the Sign in using GitHub button.

      Actual results:

      Shows a popup window with a json that has a 404 HTTP status

      Expected results:

      Either the landing page should not show the GitHub card for signing in or it should open a popup window with a GitHub authentication page (login/password) that, once populated and validated by GitHub, should close and authenticate the user in Backstage.

       

        1. app-config-rhdh-auth.yaml
          0.5 kB
          Jordi Gil
        2. image-2024-05-21-14-47-47-056.png
          9 kB
          William Siqueira
        3. Screenshot 2024-05-20 at 2.22.56 PM.png
          34 kB
          Jordi Gil

              pschultz@redhat.com Paul Schultz
              jgil@redhat.com Jordi Gil
              RHDH Frontend Plugins & UI
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Created:
                Updated:
                Resolved: