• Icon: Task Task
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • None
    • None
    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • False
    • None
    • Unset
    • None

      WidgetLayout.tsx

      initialTemplate prop and internal state management

      I would not manage the template state inside the component. Template should be mandatory, so should the onTemplateChange

      documentationLink prop

      This should not exist. If the consumer would like to customize the empty state they can use the emptyStateComponent. We can export the LayoutEmptyState component and provide an empty state customization interface there. If somebody needs to customize it, they can re-write the defaults. We want to reduce prop "bubbling" as much as possible.

      analytics prop

      This prop should not exist, it's too specific. What we should do is expose an "event interface" where we can have callbacks defined for specific events including but not limited to:

      • on drag
      • on widget add
      • on widget remove
      • etc...

      The base set of events should be all places in which the analytics prop is referenced

      drawerInstructionText prop

      I'd say this should be the same as is with the empty state. Expose the drawer and allow customization of the component rather than passing props from the root.

              Unassigned Unassigned
              aferdina@redhat.com Alexandra Ferdinand
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: