Uploaded image for project: 'Hybrid Cloud Console'
  1. Hybrid Cloud Console
  2. RHCLOUD-34619

Add a feature to Bonfire to use the full git sha reference for images to support Konflux

XMLWordPrintable

    • False
    • Hide

      None

      Show
      None
    • False
    • Unset
    • None

      Currently Bonfire tries to guess the IMAGE_TAG if not provided as part of the parameters when processing the template.

      https://github.com/RedHatInsights/bonfire/blob/cfd31f5e04f91e19685d8488d0b98562a7d934b8/bonfire/processor.py#L634-L636

      this doesn't really work on Konflux, where full git SHA is used for labels.

      currently, users wanting to deploy manually Konflux images need to manually provide the IMAGE_TAG of the components that use Konflux - and set it to be the full commit sha

      This however, can be problematic in the transition period (where some images use the shorter version of the git commit SHA, and some others use the long one), and fully activating one or the other can break either way

      I'd suggest an implementation that would enable an experimental feature that changes the behavior based on the image repository being use (and switch automatically to long git SHA if "konflux string" is found - for example, the repo being "redhat-services" is a "good enough hint" to use the long version.

      I think it's worth trying, if only to simplify local development experience as this is already solved in the Tekton Konflux pipelines by providing a manual override.

      See Slack thread for more context: https://redhat-internal.slack.com/archives/C04RP7SE1ST/p1723626533583839?thread_ts=1723460076.363069&cid=C04RP7SE1ST

            Unassigned Unassigned
            vmugicag Victor Manuel Múgica Gómez
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated: