Uploaded image for project: 'Hybrid Cloud Console'
  1. Hybrid Cloud Console
  2. RHCLOUD-19991

Bonfire: Handle sh SigKill errors properly

XMLWordPrintable

    • 1
    • False
    • Hide

      None

      Show
      None
    • False
    • Unset
    • None

      The ocviapy library is incorrectly handling sh Exceptions that have no 'stderr' output.

      The problem is here:
      https://github.com/RedHatInsights/ocviapy/blob/main/ocviapy/__init__.py#L170

      If err_lines is [] then this 'all' function call returns True:
      https://github.com/RedHatInsights/ocviapy/blob/main/ocviapy/__init__.py#L80 

      This is because all([]) evaluates to True

              bsquizza@redhat.com Brandon Squizzato
              bsquizza@redhat.com Brandon Squizzato
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: