[GSS][6.1.z]Process with subprocess marked for compensation fails to deploy on BPMS 6.1.0.ER4

+++ This bug was initially created as a clone of Bug #1191768 +++

Description of problem:

A process with a subprocess marked for compensation (isForCompensation=true) fails to deploy on BPMS 6.1.0.ER4. It deploys ok on BPMS 6.3.0.GA.

Version-Release number of selected component (if applicable): BPMS 6.1.0.ER4

How reproducible: Always reproducible

Steps to Reproduce:
1. deploy the attached kjar on BPMS 6.1.0.ER4 (GAV: org.jboss.btison.bpms.testbed.compensation:process-kjar:0.0.1)

Actual results:

Deployment fails.
Error in the log:
Error: Process 'User Task Compensation' [UserTaskCompensation]: Embedded subprocess 'Sub Process 1' [8] does not have outgoing connection.

Expected results:
Deployment succeeds.
This is a regression compared to BPMS 6.3.0.GA. The kjar deploys successfully on BPMS 6.3.0.GA

Additional info:

Root cause: class org.jbpm.ruleflow.core.validation.RuleflowProcessValidator, method validateNodes (line 463):
the code checks if the CompositeNode has outgoing connections, and throws an error if none are found.
If the CompositeNode has metadata 'isForCompensation', the absence of outgoing conmnections should not throw an exception.

— Additional comment from JBoss Product and Program Management on 2015-02-11 17:30:06 EST —

Since this issue was entered in Red Hat Bugzilla, the release flag has been
set to ? to ensure that it is properly evaluated for this release.

— Additional comment from Kris Verlaenen on 2015-02-12 07:38:22 EST —

Bernard, BPMS 6.3.0.GA doesn't exist, I assume you mean 6.0.3.GA?

— Additional comment from Bernard Tison on 2015-02-12 09:05:29 EST —

(In reply to Kris Verlaenen from comment #2)
> Bernard, BPMS 6.3.0.GA doesn't exist, I assume you mean 6.0.3.GA?

Yes,it should be 6.0.3.GA.

— Additional comment from Maciej Swiderski on 2015-02-12 11:19:32 EST —

fixed validation to take into consideration isForCompensation flag

jbpm
master:
https://github.com/droolsjbpm/jbpm/commit/2cecbdf28a5301dbad168619535255607e73493e

6.2.x:
https://github.com/droolsjbpm/jbpm/commit/fdf0179fe4e89f103b8d54b790036ce7439f0364

— Additional comment from Jiri Svitak on 2015-03-12 10:34:33 EDT —

Verified in BPM Suite 6.1.0.ER6.

QE test coverage:
https://gitlab.mw.lab.eng.bos.redhat.com/bxms/brms/commit/21459c35a4605dd508453548c31cab1f2431ae28

— Additional comment from John Skeoch on 2015-06-01 21:42:19 EDT —

User jsvitak@redhat.com's account has been closed