Uploaded image for project: 'OpenShift Request For Enhancement'
  1. OpenShift Request For Enhancement
  2. RFE-8014

Remove pre and post hook velero annotations from virt-launcher

XMLWordPrintable

    • Icon: Feature Request Feature Request
    • Resolution: Unresolved
    • Icon: Undefined Undefined
    • None
    • None
    • None
    • None
    • Product / Portfolio Work
    • None
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Summary:

      virt launcher pod seems to have velero prehook and posthook annotations by default. Request is to make this optional/configurable or remove it from the virt-launcher pod annotations?
      Annotations:
      post.hook.backup.velero.io/command: '["/usr/bin/virt-freezer", "--unfreeze", "--name", "centos-stream9-aquamarine-dragon-21", "--namespace", "test-hp-2"]'
      pre.hook.backup.velero.io/command: '["/usr/bin/virt-freezer", "--freeze", "--name", "centos-stream9-aquamarine-dragon-21", "--namespace", "test-hp-2"]'
      Issue:
      If VM is paused, then guest agent commands cannot be run and velero backup would fail.
      If guest agent has permission issues, then guest agent commands and velero backup would failĀ https://access.redhat.com/solutions/7030558.

      Upstream Issue:

      https://github.com/kubevirt/kubevirt/issues/14056

      3. Why does the customer need this? (List the business requirements here)

      1. Paused VMs: Guest agent commands cannot execute when VM is paused, causing backup failure.
      2. Guest Agent Issues: Permission problems with guest agent result in failed backups.
      3. Missing pod for a VM in provisioning state.
      4. Any other config issue where velero is not able to run the command in the pod.

      Describe the solution you'd like:
      Requesting removal of this annotation from virt launcher pod.
      Backup applications can request prehook and posthook in velerobackup job and also configure onError: Fail or Continue
      https://velero.io/docs/main/api-types/backup/

      Describe alternatives you've considered:
      Tried to set prehook and post hook in velero backup job spec but the annotations on the pod took priority.

      4. List any affected packages or components.

              rh_pelauter@redhat.com Peter Lauterbach
              seanmerrow Sean Merrow
              None
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                None
                None