Uploaded image for project: 'OpenShift Request For Enhancement'
  1. OpenShift Request For Enhancement
  2. RFE-3838

KubeletConfig controller - handle MachineConfigPool label mismatches better

XMLWordPrintable

    • None
    • Product / Portfolio Work
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      1. Proposed title of this feature request

      KubeletConfig controller - handle MachineConfigPool label mismatches better

      2. What is the nature and description of the request?

      See https://access.redhat.com/solutions/7004532 for more details

      3. Why does the customer need this? (List the business requirements here)

      We had a huge escalation because of this recently because a KubeletConfig from a PerfProfile was not applied to a node.

      4. List any affected packages or components.

      the kubeletconfig controller of the machineconfigoperator

      a) I'd suggest to use the same heuristic that we use when matching nodes to machineconfig pools:

      If an MCP matched by a KubeletConfig has multiple custom MC labels, create an error.
      If an MCP matched by a KubeletConfig has a single custom MC label and the master label, create an error.
      If an MCP matched by a KubeletConfig has a single custom MC label, use that one.
      If an MCP matched by a KubeletConfig has a single master MC label, use that one.
      If an MCP matched by a KubeletConfig has a single worker MC label, use that one.

      For backwards compatibility, the KubeletConfig probably will need a new version / flag that triggers this new behavior.

      b) At the very minimum, we should should at least error out on an inconsistent mcp

              gausingh@redhat.com Gaurav Singh
              akaris@redhat.com Andreas Karis
              None
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                None
                None