1. Proposed title of this feature request

OpenShift AWS CloudFormation Templates

2. What is the nature and description of the request?

The CloudFormation templates for AWS provided in the documentation do not adhere to best practices as done by the IPI installer and do not contain the appropriate naming/tagging conventions required for OpenShift cloud integration features to work correctly.

I know the CloudFormation templates are provided as an example for users to have the option to customize the setup to match their environment when doing a UPI install, but the CloudFormation templates should default to match what would be created by an IPI deployment as closely as possible.

To help with this, I have already taken the existing CloudFormation templates from the current documentation and made the appropriate modifications to them. They can be found here:

https://github.com/jaredhocutt/openshift4-upi

They should definitely be peer reviewed (as they have not yet), but as far as I can tell from testing myself, they are correct.

3. Why does the customer need this? (List the business requirements here)

At the moment, the CloudFormation templates do not yield a cluster that matches the naming and tagging conventions required by some features to function correctly.

Some of this is apparent by the requirements in the documentation to delete the MachineSet definitions, whereas if things are created correctly, these can be left and will work even in a UPI deployment.

Of course, keeping those docs for users that may really want full control over creating everything is important, but it's equally as important for users to know that they can still use MachineSets generated by default and that auto-scaling will work out of the box when doing a UPI install (there has been a lot of confusion around this with customers and our services organization)

4. List any affected packages or components.

https://docs.openshift.com/container-platform/4.5/installing/installing_aws/installing-aws-user-infra.html