Uploaded image for project: 'RESTEasy'
  1. RESTEasy
  2. RESTEASY-2503

After first invocation on an EJB, class/field/property constraints don't get checked

    XMLWordPrintable

Details

    • Hide
      1. Download and unzip reproducer with long name.
      2. Edit src/test/arquillian.xml and uncomment the jbossHome variable.
      3. Install a clean JBoss EAP 7.2.x
      4. Run - test will fail 
           $ mvn -Peap7 -DJBOSS_HOME=/path/to/jboss-eap-7.2 clean package verify
      5. Edit ./src/main/java/com/arquillian/DummyEjb.java and add @Valid to the parameters of both methods
      6. Run again 
           $ mvn -Peap7 -DJBOSS_HOME=/path/to/jboss-eap-7.2 clean package verify
      7. Tests will pass.

      Running with JBoss EAP 6:

         $ mvn -Peap6 -DJBOSS_HOME=/path/to/jboss-eap-6.4 clean package verify

      The tests will pass without a change. Changes must be made to the reproducer to test it JBoss EAP 7.1.6, but it has the same issue - @Valid must be defined on the subclass.

      Show
      Download and unzip reproducer with long name. Edit src/test/arquillian.xml and uncomment the jbossHome variable. Install a clean JBoss EAP 7.2.x Run - test will fail $ mvn -Peap7 -DJBOSS_HOME=/path/to/jboss-eap-7.2 clean package verify Edit ./src/main/java/com/arquillian/DummyEjb.java and add @Valid to the parameters of both methods Run again $ mvn -Peap7 -DJBOSS_HOME=/path/to/jboss-eap-7.2 clean package verify Tests will pass. Running with JBoss EAP 6: $ mvn -Peap6 -DJBOSS_HOME=/path/to/jboss-eap-6.4 clean package verify The tests will pass without a change. Changes must be made to the reproducer to test it JBoss EAP 7.1.6, but it has the same issue - @Valid must be defined on the subclass.

    Description

      When having an interface with method:

         @POST
    Response createDummy(@Valid DummyClass payload);

      And a subclass that implements it with:

         @Override
    public Response createDummy(DummyClass payload)

      The code will only validate the parameter if @Valid is added on the subclass. He interprets that as a bug. Looking at the spec, I believe he is correct, going by section 7.5

      From the JAX-RS spec

      > *Annotation Inheritance*
      > The rules for inheritance of constraint annotation are defined in [16]. It is worth noting that these rules
      > are incompatible with those defined in Section 3.6. Generally speaking, constraint annotations in [16] are
      > cumulative (can be strengthen) across a given type hierarchy while JAX-RS annotations are inherited or,
      > overridden and ignored.
      > The goal of this specification is to enable validation of JAX-RS resources by leveraging existing Bean
      > Validation implementations. Therefore, JAX-RS implementations MUST follow the constraint annotation
      > rules defined in [16].

      It appears to work with @Valid in JBoss EAP 6, though I know that implementation was tech preview.

      Attachments

        Issue Links

          causes

          Bug - A problem that impairs or prevents the functions of the product. JBEAP-18795 [GSS](7.3.z) @Valid annotation on parameter doesn't get picked up by subclass

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Verified
          is incorporated by

          Component Upgrade - A task tracking an update to a bundled component or revision of component upstream of the project. JBEAP-19076 Upgrade resteasy from 3.11.0.Final to 3.11.1.Final

          • Blocker - To be worked above all other priorities. This term is chosen when the severity of the issue is very high, has no workaround, or the effort for the change is comparatively low. Issues that may be very publicly visible and could generate significant media attention may also drive a higher priority.
          • Closed

          Component Upgrade - A task tracking an update to a bundled component or revision of component upstream of the project. WFLY-13294 Upgrade resteasy from 3.11.0.Final to 3.11.1.Final

          • Blocker - To be worked above all other priorities. This term is chosen when the severity of the issue is very high, has no workaround, or the effort for the change is comparatively low. Issues that may be very publicly visible and could generate significant media attention may also drive a higher priority.
          • Closed

          Component Upgrade - A task tracking an update to a bundled component or revision of component upstream of the project. WFLY-13326 Upgrade RESTEasy to 3.11.2.Final

          • Critical - To be worked on immediately following BLOCKER issues.
          • Closed

          Component Upgrade - A task tracking an update to a bundled component or revision of component upstream of the project. WFLY-13156 Upgrade resteasy from 3.11.0.Final to 3.11.1.Final

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed
          relates to

          Bug - A problem that impairs or prevents the functions of the product. RESTEASY-1459 Method being executed although validation fails

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Resolved

          Bug - A problem that impairs or prevents the functions of the product. RESTEASY-1008 Bean Validation + CDI + field injection not working

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Bug - A problem that impairs or prevents the functions of the product. RESTEASY-1186 Constraint violations produced by invalid parameters of a JAXRS resource method are not immediately returned in the Response returned by the method, causing business methods to be called with invalid values.

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Enhancement - An enhancement to or refactoring of existing functionality that is not configurable by an end user (typically a change made by an internal team that affects users) RESTEASY-2227 Validate fields/properties after calling @PostConstruct annotated method, if one exists

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Resolved

          Activity

            People

              rsigal@redhat.com Ronald Sigal
              rhn-support-dguthrie David Guthrie
              Votes:
              2 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: