Uploaded image for project: 'RESTEasy'
  1. RESTEasy
  2. RESTEASY-2457

reactor-netty client integration is too eager closing Response on error

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 4.4.2.Final
    • Component/s: None
    • Labels:
      None

      Description

      If there is an error during 'extracting' the response, the current reactor-netty integration closes the response and rethrows the exception (code). This was done so that reactor-netty would not leak connections. However, the rethrown exception can contain the response (e.g. WebApplicationException) and that response's body is sometimes accessed in other places. Those places typically call `isClosed` before accessing the body, which is typically buffered.

      I will soon submit a PR where we replace `close` with `releaseConnection`.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                asoldano Alessio Soldano
                Reporter:
                crankydillo1 Samuel Cox
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: