-
Story
-
Resolution: Done
-
Undefined
-
None
-
None
-
None
-
False
-
-
False
-
-
We are currentlty chasing master commits for the non-openstack puppet modules, but the upstream puppet-openstack-integration project is following latest tags [1].
This lead, in the past, to RDO hitting issue before upstream p-o-i project.
To avoid this kind of issues and to be more consistent with what we're doing for python libraries (with u-c file), we decided in last meeting [2] to pin the non-os puppet modules to the version set in upstream p-o-i Puppetfile.
To do so:
- Pin tags/bobcat-uc.yaml to last promoted commits
- Create a script to compare versions in Puppetfile with the ones in tags/bobcat-uc.yaml (pin), and propose an update only if version in Puppetfile > pin. We can start from the update_uc.py [3] script as an example. The required comparison behavior is:
- If pin/release in rdoinfo tag is > Puppetfile -> leave rdoinfo value.
- If pin/release in rdoinfo tag is < Puppetfile -> replace rdoinfo value by puppetfile value.
- If pin/release in rdoinfo tag is the exact commit hash that has the tag for the release in Puppetfile, replace the commit hash by the release value in Puppetfile.
- Add the script to the existing update-uc job [4]
[1] https://github.com/openstack/puppet-openstack-integration/blob/master/Puppetfile
[2] https://lists.rdoproject.org/archives/list/dev@lists.rdoproject.org/thread/XWNJCKSSW4O7SNIL6HO3OGX5M6MDIERZ/
[3] https://github.com/rdo-infra/releng/blob/master/rdoutils/cmd/update_uc.py
[4] https://github.com/rdo-infra/review.rdoproject.org-config/blob/master/playbooks/rdoinfo/upper-constraints-update/run.yaml