Uploaded image for project: 'Quarkus'
  1. Quarkus
  2. QUARKUS-6685

Don't create a new CORS config instance on each request handled by `DevUICORSFilter`

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • 3.NEXT
    • None
    • team/eng
    • None

      https://github.com/quarkusio/quarkus/issues/49638 shows that after https://github.com/quarkusio/quarkus/pull/49400 a new CORS config is created on each request. That was the case even before, not a new thing. But previously, the new config was simply a proxy, while I decided that we should create actual config populated with defaults because we won't remember if we ever add some default values to the CORS config to update DEV UI CORS filter. This PRs basically caches the CORS config so that it doesn't need to be created every time on each request handled by DEV UI CORS filter, thus should improve performance comparing to what was in place even before https://github.com/quarkusio/quarkus/pull/49400.

              Unassigned Unassigned
              blafond Barry LaFond
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: